Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add robot restart alert for FF changes that require restart #4285

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Oct 24, 2019

overview

Blocked by #4283, PR will be rebased when 4283 is merged Rebased and ready

This PR closes #4267 by wiring the new restart action+state from #4283 to the AdvancedSettingsCard.

Following up on what we established with buildroot, this PR also refactors robot settings into its own state subtree (robotSettings) to finally bail out of the organizational problems that have plagued the app's HTTP-fed state

changelog

  • feat(app): add robot restart alert for FF changes that require restart

review requests

Requires a robot or virtual smoothie running #4290 or later

If you want to test with virtual smoothie before 4290 is merged:

  1. Checkout 4290 branch
  2. Start API dev server
  3. Checkout this branch to run your dev app
  4. To simulate a "restart", kill your server and restart it
  5. After you kill your server, you're going to need to restart from step (1) to get virtual smoothie back on the "correct" branch

After 4290 is merged, there are no special considerations for testing with virtual smoothie

  • Change API v2 feature flag for a robot, restart modal should pop up
  • Change a different setting, restart modal should not pop up

@mcous mcous requested review from a team October 24, 2019 13:37
@mcous mcous added app Affects the `app` project feature Ticket is a feature request / PR introduces a feature ready for review labels Oct 24, 2019
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (edge@bc911ad). Click here to learn what that means.
The diff coverage is 65.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #4285   +/-   ##
=======================================
  Coverage        ?   56.57%           
=======================================
  Files           ?      887           
  Lines           ?    25131           
  Branches        ?        0           
=======================================
  Hits            ?    14217           
  Misses          ?    10914           
  Partials        ?        0
Impacted Files Coverage Δ
app/src/pages/Robots/RobotSettings.js 0% <ø> (ø)
app/src/robot-admin/actions.js 100% <ø> (ø)
app/src/reducer.js 0% <ø> (ø)
app/src/analytics/selectors.js 14.28% <0%> (ø)
...c/components/RobotSettings/AdvancedSettingsCard.js 0% <0%> (ø)
.../components/RobotSettings/RestartRequiredBanner.js 0% <0%> (ø)
app/src/pages/Calibrate/Labware.js 0% <0%> (ø)
app/src/robot-admin/epic.js 100% <100%> (ø)
app/src/robot-settings/actions.js 100% <100%> (ø)
app/src/robot-api/resources/settings.js 51.85% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc911ad...3580103. Read the comment docs.

@mcous mcous changed the base branch from app_refactor-restart to edge October 24, 2019 14:33
@mcous mcous changed the base branch from edge to app_refactor-restart October 24, 2019 14:34
@mcous mcous force-pushed the app_api-ff-restart branch from a17d3b4 to 2aa8d2c Compare October 24, 2019 15:55
@mcous mcous changed the base branch from app_refactor-restart to edge October 24, 2019 15:55
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on OT2BK111111111, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app: restart the robot when a feature flag that requires restart is changed
2 participants