Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception if a move targets the labware on the Thermocycler with lid closed #4044

Closed
btmorr opened this issue Sep 12, 2019 · 0 comments · Fixed by #4394
Closed

Raise exception if a move targets the labware on the Thermocycler with lid closed #4044

btmorr opened this issue Sep 12, 2019 · 0 comments · Fixed by #4394
Assignees
@b-cooper
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature medium
Milestone
Thermocycler: Imp...

Comments

@btmorr
Copy link
Contributor

btmorr commented Sep 12, 2019

overview

If a user/protocol sends a move command with the labware on a Thermocycler as the target and the Thermocycler lid is closed, the API should raise an exception with a message to alert the user and prevent the movement.
@btmorr btmorr added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project labels Sep 12, 2019
@btmorr btmorr added the medium label Sep 12, 2019
@b-cooper b-cooper self-assigned this Nov 6, 2019
b-cooper added a commit that referenced this issue Nov 6, 2019
@b-cooper
feat(api): warn tc-lid/gantry collision in simulation
3ca82cf 
If a given protocol would target the labware loaded into a thermocycler module, while that module is
known to be closed, simulation will fail with a helpful message.

Closes #4044
@b-cooper b-cooper mentioned this issue Nov 6, 2019
Merged
3 tasks
b-cooper added a commit that referenced this issue Nov 8, 2019
@b-cooper
feat(api): warn tc-lid/gantry collision in simulation (#4394)
b22a3b3 
If a given protocol would target the labware loaded into a thermocycler module, while that module is known to be closed, simulation will fail with a helpful message.

Closes #4044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-cooper b-cooper

Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature medium
Projects
None yet
Milestone
Thermocycler: Improved user interaction
Development

Successfully merging a pull request may close this issue.

feat(api): warn tc-lid/gantry collision in simulation Opentrons/opentrons
2 participants
@b-cooper @btmorr