Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip probe errors are not surfaced to the user #3948

Closed
mcous opened this issue Aug 27, 2019 · 0 comments · Fixed by #3959
Closed

Tip probe errors are not surfaced to the user #3948

mcous opened this issue Aug 27, 2019 · 0 comments · Fixed by #3959
Assignees
Labels
app Affects the `app` project bug

Comments

@mcous
Copy link
Contributor

mcous commented Aug 27, 2019

overview

During runtime calibration (tip probe, labware calibration), the RPC API may return an error. The app will capture that error, store it in the state, and then not tell the user anything at all.

current behavior

  • Errors are swallowed silently

steps to reproduce

  • (Carefully) perform a tip probe without a tip to induce an error
  • Notice that the app silently restarts the process without warning

expected behavior

  • If a tip probe fails, show the user an alert message with an exit button that homes the robot
@mcous mcous added bug app Affects the `app` project labels Aug 27, 2019
@mcous mcous self-assigned this Aug 27, 2019
@mcous mcous changed the title Runtime calibration errors are not surfaced to the user Tip probe errors are not surfaced to the user Aug 27, 2019
mcous added a commit that referenced this issue Aug 27, 2019
mcous added a commit that referenced this issue Aug 28, 2019
mcous added a commit that referenced this issue Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant