Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add robot logging opt-out alert #3869

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Aug 15, 2019

overview

This PR is the front-end counterpart to #3868. It adds an alert modal on a visit to the robot settings page of a robot that:

  • Has a setting with the id disableLogAggregation
  • That setting has a value of null (None in Python-land)

Closes #3867

2019-08-15 15 45 02

changelog

  • feat(app): Add robot logging opt-out alert

review requests

  • Modal pops up if value is null
  • Modal doesn't pop up if value is true or false
  • Modal doesn't interfere in weird ways with other modals (like update alerts)

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Aug 15, 2019
@mcous mcous requested review from sfoster1 and Kadee80 August 15, 2019 19:46
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #3869 into edge will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #3869      +/-   ##
==========================================
- Coverage   34.65%   34.63%   -0.02%     
==========================================
  Files         731      731              
  Lines       11617    11623       +6     
==========================================
  Hits         4026     4026              
- Misses       7591     7597       +6
Impacted Files Coverage Δ
...c/components/RobotSettings/AdvancedSettingsCard.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf68ad9...bda1b88. Read the comment docs.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲 📂

@mcous mcous merged commit 9ab6938 into edge Aug 16, 2019
@mcous mcous deleted the app_log-aggregation-opt-out branch August 21, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildroot: app: show modal for log uploading
3 participants