Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD Bug: Inner Mix asp & disp tip position should be consistent #3414

Closed
b-cooper opened this issue May 3, 2019 · 1 comment · Fixed by #3418 or #3588
Closed

PD Bug: Inner Mix asp & disp tip position should be consistent #3414

b-cooper opened this issue May 3, 2019 · 1 comment · Fixed by #3418 or #3588
Assignees
@b-cooper
Labels
bug protocol designer Affects the `protocol-designer` project

Comments

@b-cooper
Copy link
Contributor

b-cooper commented May 3, 2019

overview

@opatel0 reported this bug and associated protocol in the internal PD slack channel on May 3rd 2019.

In a given transfer step, the aspirate and dispense offsets from bottom are being used respectively in inner mixes in both source and destination. In the case where you're moving from a tube rack (~80mm tip position) to a well place (~0.5mm tip position), the mix in destination becomes totally useless as it is aspirating the air 79.5mm above the well of the destination plate.

expected behavior

The dispense tip position should be used for aspirate and dispense in a given "mix in destination", and conversely the aspirate tip position should be used for both aspirate and dispense in a given "mix in source" for MoveLiquid steps.
@b-cooper b-cooper added bug protocol designer Affects the `protocol-designer` project labels May 3, 2019
@b-cooper b-cooper self-assigned this May 3, 2019
b-cooper added a commit that referenced this issue May 6, 2019
@b-cooper
fix(protocol-designer): inner mix in move liquid predictable tip height
0753eb1 
Inner mixes for move liquid steps now aspirate and dispense at the tip position that corresponds to
the source or destination tip position setting closest to the mix in the chronology of the compound
command

Closes #3414
@b-cooper b-cooper mentioned this issue May 6, 2019
Merged
@IanLondon IanLondon mentioned this issue Jun 14, 2019
Merged
3 tasks
IanLondon added a commit that referenced this issue Jun 18, 2019
@IanLondon
feat(protocol-designer): save v3 protocols (#3588)
40f3a9e 
Closes #3336 and closes #3414

- change command creators to match v3 protocol schema
- deep refactor of test fixtures, too many hard-coded strings etc, to allow testing flow rates and offsets somewhat sanely
- remove vestigal `defaultValues` access in APIv1 executor for JSON v3 protocols
- minor changes to v3 protocol schema
- for consolidate and transfer, make touch tip happen after the destination well's inner mix, do not touch tip between the dispense and the inner mix
- redo shared-data schemaV1/schemaV3 imports - `import {NameOfType} from '@opentrons/shared-data/path/to/schemaV3` vs `import {NameOfTypeV3} from '@opentrons/shared-data'`
@IanLondon
Copy link
Contributor

For record-keeping, just rewriting what Brian said after we talked in person:

Current behavior

I set "Aspirate" section's "Tip Position" to 80mm from bottom for my tall tube rack source
I set "Dispense" section's "Tip Position" to 5mm from bottom for my shallow 96-well destination

Now if I choose the "Aspirate" mix, it will aspirate at 80mm from bottom of the tall tube (a good height), and dispense far far too deep in the tube at 5mm from bottom, potentially submerging the pipette tip.

Now if I choose the "Dispense" mix, it will aspirate 80mm above the 96 well - the well is not that tall, so it will aspirate air! Then it will dispense 5mm from bottom, which would be an OK dispense height if there was actually liquid in there.

Proposed new behavior

We have 4 heights (aspirate + dispense in source; aspirate + dispense in dest) but only 2 fields ("Aspirate" section and "Dispense" section tip height fields). So we could either:

  1. Make the tip height in "Aspirate" section control the source well aspirate+dispense height, and the tip height in the "Dispense" section control the destination well aspirate+dispense height. So now I can set the tall tube to 80mm and the 96-flat to 5mm, and I will get: Inner Mix in source tube (aspirate 80mm, dispense 80mm), aspirate 80mm from source, dispense 5mm from dest, inner mix in dest well (aspirate 5mm, dispense 5mm). No more aspirating air or plunging the pipette too deep. But I can only give one number per labware. With this approach, I cannot aspirate 80mm from the tube and dispense above the tube at let's say 110mm.
  2. Add fields so to give the user full control: aspirate in source; dispense in source; aspirate in dest; dispense in dest. We would need to add more fields to the form
  3. A variation of the above: add asp/disp fields specific to the inner mixes.

@IanLondon IanLondon reopened this Jul 8, 2019
b-cooper added a commit that referenced this issue Jul 8, 2019
@b-cooper
fix(protocol-designer): inner mix in move liquid predictable tip height
6a5b68a 
Inner mixes for move liquid steps now aspirate and dispense at the tip position that corresponds to
the source or destination tip position setting closest to the mix in the chronology of the compound
command

Closes #3414
b-cooper added a commit that referenced this issue Jul 8, 2019
@b-cooper
fix(protocol-designer): inner mix in move liquid predictable tip heig…
95feefc 
…ht (#3418)

Inner mixes for move liquid steps now aspirate and dispense at the tip position that corresponds to
the source or destination tip position setting closest to the mix in the chronology of the compound
command

Closes #3414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-cooper b-cooper

Labels
bug protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
2 participants
@b-cooper @IanLondon