feat(app): Replace P10 update warning with one for all pipettes #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #3043 +/- ##
==========================================
- Coverage 53.31% 53.16% -0.15%
==========================================
Files 677 681 +4
Lines 19683 19877 +194
==========================================
+ Hits 10494 10568 +74
- Misses 9189 9309 +120
Continue to review full report at Codecov.
|
Kadee80
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
🐷
Tests on VS
- App shows modal
- Clicking "OK" sets "useOldAspirationFunctions": false, modal does not reappear
- Clicking "Go to advanced settings" sets "useOldAspirationFunctions": false, modal does not reappear
- Clicking "Go to advanced settings" scrolls to the "Use older pipette calibrations" toggle
Laura-Danielle
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
📴
- App shows modal
- Clicking "OK" sets "useOldAspirationFunctions": false, modal does not reappear
- Clicking "Go to advanced settings" sets "useOldAspirationFunctions": false, modal does not reappear
- Clicking "Go to advanced settings" scrolls to the "Use older pipette calibrations" toggle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Closes #3011
This PR replaces the previous P10 calibration update opt-in modal with an across-the-board pipette calibration opt-out modal.
Note: exact copy of modal is still in flux and may result in some
fixuppusheschangelog
review requests
Can test with real robot or virtual smoothie. If using a real robot, ensure that the robot is on a commit after 256d736 (#3029) so that it has the latest API changes necessary for this feature.
feature_flags.jsonhas"useOldAspirationFunctions": null~/.opentrons/feature_flags.json/data/feature_flags.json"useOldAspirationFunctions": false, modal does not reappear"useOldAspirationFunctions": false, modal does not reappear