Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should warn user before run that not all required modules are connected #2676

Closed
simonchih opened this issue Nov 14, 2018 · 1 comment · Fixed by #3994
Closed

App should warn user before run that not all required modules are connected #2676

simonchih opened this issue Nov 14, 2018 · 1 comment · Fixed by #3994
Assignees
Labels
app Affects the `app` project bug

Comments

@simonchih
Copy link

simonchih commented Nov 14, 2018

overview

Temperature deck works fine if script only load temperature deck and temperature deck is connected, but it will end at start if script load Temperature and Magnetic deck but only one deck is connected.

current behavior

Opentrons GUI app will end at start if script load Temperature and Magnetic deck but only connect one.

steps to reproduce

Version: v3.5.1

  1. Open Opentrons GUI app
  2. Check only temperature deck is connected
  3. Upload script that load temperature and magnetic deck below:
    md.py
  4. Start script
    ==> It will end at start immediately.

Note:
It works fine if script only load temperature deck.
script below:
md_Laura.py

expected behavior

OT2 app will end at start, but user won’t know what happened.
Please add error message "NOT all hardware modules are connected" at OT app stop to run.

@simonchih simonchih changed the title Temperature deck end at start if using wrap function Temperature deck end at start if loading Temperature and Magnetic deck but only connect one Nov 16, 2018
@simonchih simonchih changed the title Temperature deck end at start if loading Temperature and Magnetic deck but only connect one OT App end at start if loading Temperature and Magnetic deck but only connect one Nov 16, 2018
@mcous mcous added app Affects the `app` project bug labels Aug 29, 2019
@mcous mcous changed the title OT App end at start if loading Temperature and Magnetic deck but only connect one App should warn user before run that not all required modules are connected Aug 29, 2019
@mcous
Copy link
Contributor

mcous commented Sep 3, 2019

Proposed fix: disable the "Run" button in the run page with a tooltip that says "Please attach all required modules to your robot before running your protocol"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants