Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Log tracebacks from failed RPC calls #1846

Merged
merged 4 commits into from
Jul 10, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jul 10, 2018

overview

This PR adds traceback reporting to the RPC server for failed remote calls and logs them in the app when they are passed over from the worker.

Closes #1841

changelog

  • feat(app): Log tracebacks from failed RPC calls

review requests

  1. Launch app with devtools enabled
  2. Load bad protocol onto virtual smoothie (or a robot with this branch pushed)
  • Traceback from robot shows up
  1. Load bad protocol onto robot that is on an earlier branch
  • Error message shows up still in UI

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Jul 10, 2018
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☔️ ⛱ 🌂

@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #1846 into edge will increase coverage by 0.29%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #1846      +/-   ##
==========================================
+ Coverage   34.55%   34.84%   +0.29%     
==========================================
  Files         380      380              
  Lines        6176     6224      +48     
==========================================
+ Hits         2134     2169      +35     
- Misses       4042     4055      +13
Impacted Files Coverage Δ
app/src/rpc/client.js 94.65% <100%> (+0.08%) ⬆️
app/src/rpc/remote-error.js 100% <100%> (ø) ⬆️
app/src/robot/api-client/index.js 5.26% <12.5%> (+5.26%) ⬆️
app/src/robot/selectors.js 82.1% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619e2d9...1f41b94. Read the comment docs.

@mcous mcous merged commit 0c07c52 into edge Jul 10, 2018
@mcous mcous deleted the rpc_include-traceback-with-error branch July 10, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants