Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Remote call errors should include traceback for logging in the app #1841

Closed
rvinzent opened this issue Jul 9, 2018 · 1 comment · Fixed by #1845
Closed

RPC: Remote call errors should include traceback for logging in the app #1841

rvinzent opened this issue Jul 9, 2018 · 1 comment · Fixed by #1845
Assignees
Labels
api Affects the `api` project app Affects the `app` project feature Ticket is a feature request / PR introduces a feature small

Comments

@rvinzent
Copy link
Contributor

rvinzent commented Jul 9, 2018

current behavior

Only the error message is displayed when there is an error loading a Python script. I think it would be beneficial to be able to see the full traceback. There are some situations when writing protocols where it would be highly beneficial to see the full traceback especially without access to the debugger.

expected behavior

I am proposing that the full traceback be displayed when the developer tools option is turned on.

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project api Affects the `api` project labels Jul 10, 2018
@mcous
Copy link
Contributor

mcous commented Jul 10, 2018

Hey @rvinzent, thanks for the request!

Good idea, the traceback in the console / app logs would be useful in these situations. I just did some experimenting, and it's not too hard to tweak things so the API sends it over to the app in the event of an error. Gonna see if I can sneak this in tomorrow

@mcous mcous changed the title FEATURE REQUEST: Show full traceback when developer tools are enabled RPC: Remote call errors should include traceback for logging in the app Jul 10, 2018
@mcous mcous added the small label Jul 10, 2018
@mcous mcous self-assigned this Jul 10, 2018
mcous added a commit that referenced this issue Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project app Affects the `app` project feature Ticket is a feature request / PR introduces a feature small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants