Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should show error alert if protocol run errors out #1828

Closed
mcous opened this issue Jul 6, 2018 · 0 comments
Closed

App should show error alert if protocol run errors out #1828

mcous opened this issue Jul 6, 2018 · 0 comments
Assignees
Labels
app Affects the `app` project bug small

Comments

@mcous
Copy link
Contributor

mcous commented Jul 6, 2018

overview

As a user, I would like to know if my protocol run fails for some reason. Blocked by #2994

current behavior

Currently, the app suppresses protocol run errors because "Cancel" (which triggers a smoothie halt) emits an error. This means that legitimate errors are also suppressed, so if the protocol run errors, the user can't really tell that the run errored (or even stopped).

steps to reproduce

  1. Upload a protocol
  2. Start a run
  3. Trigger an error (smoothie limit switch?)
  4. Observe that the app doesn't really do anything

expected behavior

If an error happens during a protocol run, the app should show the user an error.

@mcous mcous added bug app Affects the `app` project labels Jul 6, 2018
@btmorr btmorr added the blocked Ticket or PR is blocked by other work label Jan 31, 2019
@mcous mcous self-assigned this Jul 15, 2019
@mcous mcous added small and removed blocked Ticket or PR is blocked by other work labels Jul 15, 2019
mcous added a commit that referenced this issue Jul 15, 2019
@mcous mcous closed this as completed in 73d06d8 Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug small
Projects
None yet
Development

No branches or pull requests

2 participants