fix(app): fix small bugs on ODD #13618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13618 +/- ##
====================================================
Coverage 71.30% 71.30%
====================================================
Files 2425 2425
Lines 68193 68193
Branches 7949 7949
====================================================
Hits 48628 48628
Misses 17703 17703
Partials 1862 1862
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
commented
Sep 21, 2023
Comment on lines
+105
to
+107
| css={css` | ||
| word-break: break-word; | ||
| `} |
There was a problem hiding this comment.
Using css since wordBreak="break-word" doesn't work.
I think at some point we would need to update StyleProps to add new css properties.
I guess we will be able to work on this when we start working on the design system unification.
There was a problem hiding this comment.
Totally agree. It would make things a bit easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix failed run modal text wrapping issue and RunSummary splash screen's textTransform issue.
before
after
close RAUT-703 and RAUT-704
Test Plan
Changelog
Review requests
Risk assessment
low