Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): do not open jaw after gripper calibration #13165

Merged

Conversation

ahiuchingau
Copy link
Contributor

Overview

We don't need to ungrip the jaw whenever we finishes calibration, because holding the jaw closed is the ideal gripper state, we can just leave it as that.

@ahiuchingau ahiuchingau requested a review from a team as a code owner July 25, 2023 20:23
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #13165 (3d3b609) into edge (57b7c9b) will not change coverage.
Report is 6 commits behind head on edge.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13165   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files        2359     2359           
  Lines       64994    64994           
  Branches     7213     7213           
=======================================
  Hits        47143    47143           
  Misses      16105    16105           
  Partials     1746     1746           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ahiuchingau ahiuchingau changed the base branch from edge to internal-release_0.14.0 July 25, 2023 21:10
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grand to me

@sfoster1 sfoster1 merged commit bd13403 into internal-release_0.14.0 Jul 26, 2023
@sfoster1 sfoster1 deleted the do-not-ungrip-jaw-after-calibration branch July 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants