fix(hardware-testing): 96ch photometric confirm volume at beginning #13041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
approved these changes
Jul 5, 2023
…m-volume-at-beginning
Codecov Report
@@ Coverage Diff @@
## edge #13041 +/- ##
==========================================
- Coverage 72.28% 72.28% -0.01%
==========================================
Files 2370 2370
Lines 65029 65029
Branches 7279 7279
==========================================
- Hits 47008 47005 -3
- Misses 16322 16323 +1
- Partials 1699 1701 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
andySigler
force-pushed
the
fix-hardware-testing-96ch-photometric-confirm-volume-at-beginning
branch
from
1b60ad9 to
4824ce6
Compare
andySigler
deleted the
fix-hardware-testing-96ch-photometric-confirm-volume-at-beginning
branch
andySigler
added a commit
that referenced
this pull request
Jul 12, 2023
andySigler
added a commit
that referenced
this pull request
Jul 12, 2023
andySigler
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If the 96ch is tilted then the volume in the reservoir may need to be greater than specified, so this PR adds a step where the operator can add more liquid at the beginning of the test-run if needed.
Test Plan
Changelog
Review requests
Risk assessment