fix(shared-data): exclude module calibration adapters from being rendered. #12971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #12971 +/- ##
==========================================
+ Coverage 72.77% 72.87% +0.09%
==========================================
Files 2364 2351 -13
Lines 64501 64461 -40
Branches 7219 7190 -29
==========================================
+ Hits 46943 46973 +30
+ Misses 15879 15805 -74
- Partials 1679 1683 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shared-data/js/getLabware.ts
Outdated
Comment on lines
40
to
43
| 'opentrons_calibration_adapter_heatershaker_module', | ||
| 'opentrons_calibration_adapter_magnetic_module', | ||
| 'opentrons_calibration_adapter_temperature_module', | ||
| 'opentrons_calibration_adapter_thermocycler_module', |
There was a problem hiding this comment.
Nit: Can we move these below the TODO(lc 8-24-2022) comment below? Right now, the comment above makes it look like these are for "back-compat with legacy v1 defs."
Also, do we need these in PD_DO_NOT_LIST too?
There was a problem hiding this comment.
will do,
and I'm not sure,
@b-cooper do we also want to add to PD_DO_NOT_LIST ?
jerader
approved these changes
Jun 28, 2023
ewagoner
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Module calibration adapters are labware but meant for internal uses so we want to exclude them so they aren't rendered on the app.
Closes: RQA-811
Test Plan
Changelog
LABWAREV2_DO_NOT_LISTin shared-data so they are excluded when rendering.Review requests
Does this make sense?
Risk assessment
low