-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for empty mounts in provisioning script #12961
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12961 +/- ##
=======================================
Coverage 72.91% 72.91%
=======================================
Files 2349 2349
Lines 64380 64392 +12
Branches 7167 7167
=======================================
+ Hits 46943 46954 +11
- Misses 15761 15762 +1
Partials 1676 1676
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -20,36 +19,81 @@ | |||
RIGHT_PIPETTE_ENV_VAR_NAME = "RIGHT_OT3_PIPETTE_DEFINITION" | |||
|
|||
|
|||
@dataclass | |||
class OT3PipetteEnvVar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you just keep this a data class with defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or keep it a dataclass and use a build
classmethod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop making so much sense. I have no idea why I did it that way. I will go back and fix it.
If I remember the reason I did it that way, and the reason makes sense, I will drop a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remembered my reasoning for doing it that way.
My reasoning was not good.
Here is the fix
262d21e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Add support for empty pipette mounts.
Test Plan
Changelog
Review requests
None
Risk assessment
Low