Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add validation that pipette eeproms are created correctly #270

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

DerekMaggio
Copy link
Contributor

Overview

Add validation that size of eeprom.bin file is greater than 0 if a pipette is mounted

Changelog

  • Add left_pipette_expected and right_pipette_expected fields to SystemTestDefinition
  • Modify the 3 sample files under test to have different pipette configurations
  • Add logic to get size of eeprom.bin files

Review requests

None

Risk assessment

Low

@DerekMaggio DerekMaggio requested review from sfoster1 and fsinapi June 22, 2023 19:35
@DerekMaggio
Copy link
Contributor Author

Want to get Opentrons/opentrons#12961 merged first so the e2e tests pass

Copy link
Contributor

@fsinapi fsinapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah LGTM if e2e passes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants