Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-api-client, app): fix failing tests (#12710) #12712

Merged
merged 1 commit into from
May 16, 2023

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented May 16, 2023

Overview

Grab fix for failing tests from internal-release_0.8.0 into edge

PR into internal-release_0.8.0

@b-cooper b-cooper requested review from a team as code owners May 16, 2023 16:38
@b-cooper b-cooper requested review from jerader, sfoster1 and shlokamin and removed request for a team and jerader May 16, 2023 16:38
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #12712 (30dba80) into edge (92e8f4b) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12712      +/-   ##
==========================================
+ Coverage   73.04%   73.35%   +0.30%     
==========================================
  Files        1482     2261     +779     
  Lines       48173    61484   +13311     
  Branches     3021     6782    +3761     
==========================================
+ Hits        35189    45102    +9913     
- Misses      12520    14763    +2243     
- Partials      464     1619    +1155     
Flag Coverage Δ
app 71.66% <ø> (+27.62%) ⬆️
react-api-client 72.85% <ø> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 780 files with indirect coverage changes

@b-cooper b-cooper merged commit b8ebbbe into edge May 16, 2023
@b-cooper b-cooper deleted the chore_cherry-pick-app-test-fix-from-080 branch May 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants