Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): change the format of the motor usage response #12541

Merged
merged 10 commits into from
Apr 21, 2023

Conversation

ryanthecoder
Copy link
Contributor

Overview

The new format lets us be more flexible on what is sent back from each motor as we add more and different keys to each one.
new motor usage payload needs its own special parser

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner April 21, 2023 15:30
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a good TLV

@ryanthecoder ryanthecoder force-pushed the RLAB-291-change-motor-usage-can-format branch from 42f202e to 0469c58 Compare April 21, 2023 16:09
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #12541 (1333560) into edge (34eec84) will decrease coverage by 0.12%.
The diff coverage is 41.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12541      +/-   ##
==========================================
- Coverage   73.69%   73.57%   -0.12%     
==========================================
  Files        2263     2266       +3     
  Lines       62137    62368     +231     
  Branches     6587     6587              
==========================================
+ Hits        45792    45888      +96     
- Misses      14782    14917     +135     
  Partials     1563     1563              
Flag Coverage Δ
hardware 58.64% <41.26%> (-0.61%) ⬇️
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hardware/opentrons_hardware/scripts/dump_eeprom.py 0.00% <0.00%> (ø)
...rons_hardware/firmware_bindings/messages/fields.py 57.39% <34.21%> (-4.59%) ⬇️
...ns_hardware/firmware_bindings/messages/payloads.py 95.43% <42.10%> (-3.81%) ⬇️
.../opentrons_hardware/firmware_bindings/constants.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@ryanthecoder ryanthecoder merged commit 5efec97 into edge Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants