Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0 Feedback: app no longer syncs robot time #10804

Closed
mcous opened this issue Jun 16, 2022 · 2 comments
Closed

6.0 Feedback: app no longer syncs robot time #10804

mcous opened this issue Jun 16, 2022 · 2 comments
Assignees
Labels
6.0-feedback Feedback for the 6.0 release app Affects the `app` project complete Completely resolved and/or verified fixed.

Comments

@mcous
Copy link
Contributor

mcous commented Jun 16, 2022

Overview

Prior to the OT-2R, OT-2's did not ship with a real-time clock module installed. This means that whenever an OT-2OG is turned off, it loses track of the time.

To account for this, #6501 added functionality to the app that would sync the OT-2's clock with the user's computer at the time the "Connect" button/toggle was pressed. The v6 app seems to have removed this behavior, which will cause large and confusing time differences between non-refresh OT-2s and the app anywhere timestamps are used.

(This also affects OT-2Rs whose RTC's backup battery has died, which will take several years of operation to drain)

Current Behavior

The app never checks or sets the OT-2's clock.

Expected Behavior

At some point before a robot is used or interacted with, the app should:

  1. Check the robot's time
  2. If the robot's time disagrees by some threshold with the app, set the robot's time
    • <= v5 app uses 60 seconds as the threshold

Steps To Reproduce

No response

Operating system

No response

Robot setup or anything else?

See https://github.com/Opentrons/opentrons/blob/f003365aa47b3906f5ff6b3162e200d786043a5e/app/src/redux/robot-admin/epic/syncTimeOnConnectEpic.ts for previous sync time logic

@mcous mcous added the 6.0-feedback Feedback for the 6.0 release label Jun 16, 2022
@bndo
Copy link
Contributor

bndo commented Jun 23, 2022

Connect to clock before the run is created.

@b-cooper b-cooper self-assigned this Jun 24, 2022
@mikecardarelli
Copy link

I think we can live without this for the next BETA release.

@y3rsh y3rsh added the app Affects the `app` project label Jun 28, 2022
b-cooper added a commit that referenced this issue Jun 28, 2022
Instead of anchoring the system clock syncing off of the now orphaned robot connect action, create
an explicit sync time action and dispatch it on mount of the device and run details pages.

Closes #10804
b-cooper added a commit that referenced this issue Jun 28, 2022
Instead of anchoring the system clock syncing off of the now orphaned robot connect action, create
an explicit sync time action and dispatch it on mount of the device and run details pages.

Closes #10804
@y3rsh y3rsh added the complete Completely resolved and/or verified fixed. label Jul 1, 2022
@y3rsh y3rsh closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0-feedback Feedback for the 6.0 release app Affects the `app` project complete Completely resolved and/or verified fixed.
Projects
None yet
Development

No branches or pull requests

6 participants