Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid Setup in PD: add liquid color field #10601

Closed
3 tasks done
skyewindsor opened this issue Jun 3, 2022 · 0 comments · Fixed by #10958
Closed
3 tasks done

Liquid Setup in PD: add liquid color field #10601

skyewindsor opened this issue Jun 3, 2022 · 0 comments · Fixed by #10958
Assignees
@sakibh
Labels
protocol designer Affects the `protocol-designer` project

Comments

@skyewindsor
Copy link
Contributor

skyewindsor commented Jun 3, 2022 •
edited by sakibh
Loading

Overview

We need to add a liquid color field to the liquids tab in Protocol Designer.

Implementation details

This will be a dynamic field based on the color picker work outlined in this ticket.

Design

https://www.figma.com/file/2xjSLHXquNsKvC1mV9NMjr/Milestone-2?node-id=955%3A144974

Acceptance criteria

  • "Color" field appears on liquid setup page
  • Color field hover state renders the same as other input fields
  • Color picker window opens when color field clicked on
@skyewindsor skyewindsor added feature-request A request for a new feature or a change that isn't a bug. May require further triage or scoping. protocol designer Affects the `protocol-designer` project and removed feature-request A request for a new feature or a change that isn't a bug. May require further triage or scoping. labels Jun 3, 2022
@sakibh sakibh self-assigned this Jun 21, 2022
sakibh added a commit that referenced this issue Jun 30, 2022
@sakibh
feat(protocol-designer): add custom liquid color picker
f33ff39 
This PR adds a custom liquid color picker and field to the liquids page in Protocol Designer.

closes #10573, closes #10601
@sakibh sakibh mentioned this issue Jun 30, 2022
Merged
sakibh added a commit that referenced this issue Jul 11, 2022
@sakibh @smb2268
feat(protocol-designer): add custom liquid color picker (#10958)
b4a11af 
* feat(protocol-designer): add custom liquid color picker

This PR adds a custom liquid color picker and field to the liquids page in Protocol Designer. closes #10573, closes #10601

Co-authored-by: smb2268 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakibh sakibh

Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol-designer): add custom liquid color picker Opentrons/opentrons
2 participants
@sakibh @skyewindsor