Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Robot stops advertising itself when another device has the same name #10126

Closed
SyntaxColoring opened this issue Apr 28, 2022 · 1 comment · Fixed by #10559
Closed

bug: Robot stops advertising itself when another device has the same name #10126

SyntaxColoring opened this issue Apr 28, 2022 · 1 comment · Fixed by #10559
Assignees
Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). update server

Comments

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Apr 28, 2022

Overview

If a robot has the same name as another device on the network, the robot will stop advertising itself to the Opentrons App and other users of our discovery-client.

Steps to reproduce

  1. Have two robots.
  2. Make sure both robots are advertising themselves.
    • They should both show up and be connectable in the Opentrons App.
    • On macOS, dns-sd -B should show them both.
    • The discovery client (cd discovery-client && yarn discovery browse) should show them both.
  3. Rename one robot to foo.
    • You can do this with the 6.0 beta Opentrons App. Or, you can manually issue an HTTP POST to robot_ip:31950/server/name {"name": "foo"} with a tool like curl or Postman.
  4. Rename the other robot to foo, also.
  5. Wait a few moments.

Current behavior

  • In the Opentrons App, one of the robots will drop to the "Unable to locate this robot" state. (You may need to hit Refresh List to trigger this.)
  • dns-sd -B will only show one of the robots.
  • yarn discovery browse will only show one of the robots.

Expected behavior

Both robots should remain discoverable through the Opentrons App, dns-sd, and yarn discovery browse.

Bug details

@SyntaxColoring SyntaxColoring added bug update server robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Apr 28, 2022
@SyntaxColoring
Copy link
Contributor Author

SyntaxColoring commented Apr 28, 2022

Solution paths

Flesh out our D-Bus code

Flesh out our D-Bus code to feed Avahi a new name whenever it detects a conflict.

Delete our D-Bus code and configure Avahi with a static service file

See #10199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). update server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants