Skip to content

Commit

Permalink
feat(protocol-designer): add 'drop tip' to 'dispense' section of form (
Browse files Browse the repository at this point in the history
…#1998)

- command creators & tests already are set up for this!

Closes #1689
  • Loading branch information
IanLondon authored Aug 3, 2018
1 parent 7ebff4d commit fa47f85
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ const TransferLikeForm = (props: TransferLikeFormProps) => {
<div className={formStyles.row_wrapper}>
<div className={styles.left_settings_column}>
<FormGroup label='TECHNIQUE'>
<StepCheckboxRow name="dispense_touchTip" label="Touch tip" />
<StepCheckboxRow name="dispense_mix_checkbox" label='Mix'>
<StepInputField name="dispense_mix_volume" units="μL" {...focusHandlers} />
<StepInputField name="dispense_mix_times" units="Times" {...focusHandlers} />
Expand Down
1 change: 1 addition & 0 deletions protocol-designer/src/form-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export type TransferLikeForm = {|
'volume'?: string,
'dispense_labware'?: string,
'dispense_wells'?: Array<string>,
'dispense_touchTip'?: boolean,
'dispense_mix_checkbox'?: boolean,
'dispense_mix_volume'?: string,
'dispense_mix_times'?: string
Expand Down
1 change: 1 addition & 0 deletions protocol-designer/src/steplist/fieldLevel/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export type StepFieldName =
| 'dispense_delayMinutes'
| 'dispense_delaySeconds'
| 'dispense_labware'
| 'dispense_touchTip'
| 'dispense_mix_checkbox'
| 'dispense_mix_times'
| 'dispense_mix_volume'
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/src/steplist/formProcessing.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ function _vapTransferLike (
mixInDestination,
preWetTip: formData['aspirate_preWetTip'] || false,
touchTipAfterAspirate: formData['aspirate_touchTip'] || false,
touchTipAfterDispense: false, // TODO Ian 2018-03-01 Not in form
touchTipAfterDispense: formData['dispense_touchTip'] || false,
description: 'description would be here 2018-03-01' // TODO get from form
}

Expand Down

0 comments on commit fa47f85

Please sign in to comment.