address comments

Opentrons · Mar 5, 2024 · ed2bd00 · ed2bd00
1 parent ce38dfb
commit ed2bd00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app-shell-odd/electron-builder.config.js b/app-shell-odd/electron-builder.config.js
@@ -1,9 +1,9 @@
 'use strict'
-const { app } = require('electron')
+import pkg from '../package.json'
 
 module.exports = {
   appId: 'com.opentrons.odd',
-  electronVersion: app.getVersion(),
+  electronVersion: JSON.stringify(pkg.devDependencies.electron),
   npmRebuild: false,
   files: [
     '**/*',

diff --git a/app-shell/electron-builder.config.js b/app-shell/electron-builder.config.js
@@ -1,7 +1,7 @@
 'use strict'
 const path = require('path')
 const { versionForProject } = require('../scripts/git-version')
-const { app } = require('electron')
+const pkg = require('../package.json')
 
 const {
   OT_APP_DEPLOY_BUCKET,
@@ -26,7 +26,7 @@ const publishConfig =
 module.exports = async () => ({
   appId:
     project === 'robot-stack' ? 'com.opentrons.app' : 'com.opentrons.appot3',
-  electronVersion: app.getVersion(),
+  electronVersion: JSON.stringify(pkg.devDependencies.electron),
   npmRebuild: false,
   releaseInfo: {
     releaseNotesFile: