adress PR comments

Opentrons · Dec 6, 2023 · db5e758 · db5e758
1 parent 4f883a9
commit db5e758
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/api/src/opentrons/protocol_api/core/legacy/legacy_instrument_core.py b/api/src/opentrons/protocol_api/core/legacy/legacy_instrument_core.py
@@ -533,4 +533,4 @@ def configure_nozzle_layout(
 
     def get_active_channels(self) -> int:
         """This will never be called because it was added in API 2.16."""
-        return 0
+        assert False, "get_active_channels only supported in API 2.16 & later"
diff --git a/api/src/opentrons/protocol_api/core/legacy_simulator/legacy_instrument_core.py b/api/src/opentrons/protocol_api/core/legacy_simulator/legacy_instrument_core.py
@@ -451,4 +451,4 @@ def configure_nozzle_layout(
 
     def get_active_channels(self) -> int:
         """This will never be called because it was added in API 2.16."""
-        return 0
+        assert False, "get_active_channels only supported in API 2.16 & later"
diff --git a/api/src/opentrons/protocol_engine/state/tips.py b/api/src/opentrons/protocol_engine/state/tips.py
@@ -67,7 +67,7 @@ def handle_action(self, action: Action) -> None:
                 self._state.channels_by_pipette_id[pipette_id] = config.channels
                 self._state.active_channels_by_pipette_id[pipette_id] = config.channels
             self._handle_command(action.command)
-            # TODO: add test for this
+
             if isinstance(action.private_result, PipetteNozzleLayoutResultMixin):
                 pipette_id = action.private_result.pipette_id
                 nozzle_map = action.private_result.nozzle_map