fix(api,app,shared-data): Fix LPC for protocols using the plate reade…

…r module. (#16453)
Opentrons · Oct 11, 2024 · daf2280 · daf2280
1 parent ca6488f
commit daf2280
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/api/src/opentrons/protocol_engine/commands/load_module.py b/api/src/opentrons/protocol_engine/commands/load_module.py
@@ -5,6 +5,7 @@
 from pydantic import BaseModel, Field
 
 from .command import AbstractCommandImpl, BaseCommand, BaseCommandCreate, SuccessData
+from ..errors import ModuleNotLoadedError
 from ..errors.error_occurrence import ErrorOccurrence
 from ..types import (
     DeckSlotLocation,
@@ -159,11 +160,14 @@ async def execute(
             and params.model == ModuleModel.ABSORBANCE_READER_V1
             and params.moduleId is not None
         ):
-            abs_reader = self._equipment.get_module_hardware_api(
-                self._state_view.modules.get_absorbance_reader_substate(
-                    params.moduleId
-                ).module_id
-            )
+            try:
+                abs_reader = self._equipment.get_module_hardware_api(
+                    self._state_view.modules.get_absorbance_reader_substate(
+                        params.moduleId
+                    ).module_id
+                )
+            except ModuleNotLoadedError:
+                abs_reader = None
 
             if abs_reader is not None:
                 result = await abs_reader.get_current_lid_status()

diff --git a/app/src/organisms/LabwarePositionCheck/useLaunchLPC.tsx b/app/src/organisms/LabwarePositionCheck/useLaunchLPC.tsx
@@ -15,7 +15,10 @@ import { getLabwareDefinitionsFromCommands } from '/app/molecules/Command/utils/
 
 import type { RobotType } from '@opentrons/shared-data'
 
-const filteredLabware = ['opentrons_tough_pcr_auto_sealing_lid']
+const filteredLabware = [
+  'opentrons_tough_pcr_auto_sealing_lid',
+  'opentrons_flex_lid_absorbance_plate_reader_module',
+]
 
 export function useLaunchLPC(
   runId: string,

diff --git a/app/src/organisms/LabwarePositionCheck/utils/getProbeBasedLPCSteps.ts b/app/src/organisms/LabwarePositionCheck/utils/getProbeBasedLPCSteps.ts
@@ -73,7 +73,12 @@ function getAllCheckSectionSteps(
     []
   )
 
-  return labwareLocations.map(
+  // HACK: Remove LPC for plate reader to unblock science.
+  const filteredLabwareLocations = labwareLocations.filter(labware => {
+    return labware.location?.moduleModel !== 'absorbanceReaderV1'
+  })
+
+  return filteredLabwareLocations.map(
     ({ location, labwareId, moduleId, adapterId, definitionUri }) => ({
       section: SECTIONS.CHECK_POSITIONS,
       labwareId: labwareId,

diff --git a/shared-data/labware/definitions/2/opentrons_flex_lid_absorbance_plate_reader_module/1.json b/shared-data/labware/definitions/2/opentrons_flex_lid_absorbance_plate_reader_module/1.json
@@ -32,7 +32,7 @@
   "namespace": "opentrons",
   "version": 1,
   "schemaVersion": 2,
-  "allowedRoles": ["fixture"],
+  "allowedRoles": ["fixture", "lid"],
   "gripForce": 21.0,
   "gripHeightFromLabwareBottom": 48.0,
   "cornerOffsetFromSlot": {