Skip to content

Commit

Permalink
Todo comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
SyntaxColoring committed Oct 21, 2024
1 parent b59f51c commit da72776
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
11 changes: 11 additions & 0 deletions api/src/opentrons/protocol_engine/actions/get_state_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,14 @@ def get_state_update(action: Action) -> StateUpdate | None:
return action.state_update
else:
return None

# FIX BEFORE MERGE:
# If it's a FailCommandAction, and the error recovery policy was
# "assume false-positive and continue," there are actually two StateUpdates
# that we need to return here:
#
# 1. The "main" one from the command failure.
# 2. The "extra" one from assuming it's a false-positive and fixing things up
# so we're ready to continue.
#
# Or we need to merge them into a single update or something.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ async def execute(self, params: DropTipInPlaceParams) -> _ExecuteReturn:
)
],
)
return DefinedErrorData(public=error, state_update=state_update)
# FIX BEFORE MERGE: state_update_if_false_positive
return DefinedErrorData(
public=error,
state_update=state_update,
)
else:
state_update.update_pipette_tip_state(
pipette_id=params.pipetteId, tip_geometry=None
Expand Down

0 comments on commit da72776

Please sign in to comment.