Skip to content

Commit

Permalink
comments requested in code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jbleon95 committed Jan 29, 2024
1 parent 66feff8 commit cf51345
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
6 changes: 6 additions & 0 deletions api/src/opentrons/protocol_api/core/engine/protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ def append_disposal_location(
elif isinstance(disposal_location, WasteChute):
# TODO(jbl 2024-01-25) hardcoding this specific addressable area should be refactored
# when analysis is fixed up
#
# We want to tell Protocol Engine that there's a waste chute in the waste chute location when it's loaded,
# so analysis can prevent the user from doing anything that would collide with it. At the same time, we
# do not want to create a false negative when it comes to addressable area conflict. We therefore use the
# addressable area `1ChannelWasteChute` because every waste chute cutout fixture provides it and it will
# provide the engine with the information it needs.
self._engine_client.state.addressable_areas.raise_if_area_not_in_deck_configuration(
"1ChannelWasteChute"
)
Expand Down
7 changes: 6 additions & 1 deletion api/src/opentrons/protocol_engine/actions/actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ class AddLiquidAction:

@dataclass(frozen=True)
class AddAddressableAreaAction:
"""Add an addressable area to state."""
"""Add a single addressable area to state.
This differs from the deck configuration in PlayAction which sends over a mapping of cutout fixtures.
This action will only load one addressable area and that should be pre-validated before being sent via
the action.
"""

addressable_area: AddressableAreaLocation

Expand Down

0 comments on commit cf51345

Please sign in to comment.