Skip to content

Commit

Permalink
Replace todo with note.
Browse files Browse the repository at this point in the history
  • Loading branch information
SyntaxColoring committed Apr 8, 2024
1 parent 97b0ada commit cf1e936
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions api/src/opentrons/protocol_engine/state/tips.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,8 @@ def _handle_failed_command(
labware_id=action.running_command.params.labwareId,
well_name=action.running_command.params.wellName,
)
# TODO(mm, 2024-04-01): We're logically removing the tip from the tip rack,
# but we're not logically updating the pipette to have that tip on it,
# which is inconsistent and confusing.
#
# To fix that, we need the tip length. But that traditionally comes to us
# through the command result, which we don't have if the command failed. We
# may need to expand failed commands to have a private result.
# Note: We're logically removing the tip from the tip rack,
# but we're not logically updating the pipette to have that tip on it.

def _set_used_tips( # noqa: C901
self, pipette_id: str, well_name: str, labware_id: str
Expand Down

0 comments on commit cf1e936

Please sign in to comment.