Skip to content

Commit

Permalink
fixup: remove speculative load method
Browse files Browse the repository at this point in the history
  • Loading branch information
mcous committed May 3, 2021
1 parent ff19ce7 commit c6667d9
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 25 deletions.
5 changes: 0 additions & 5 deletions api/src/opentrons/file_runner/abstract_file_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
class AbstractFileRunner(ABC):
"""Abstract interface for an object that can run protocol files."""

@abstractmethod
def load(self) -> None:
"""Prepare to run the protocol file."""
...

@abstractmethod
def play(self) -> None:
"""Start (or un-pause) running the protocol file."""
Expand Down
4 changes: 0 additions & 4 deletions api/src/opentrons/file_runner/json_file_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
class JsonFileRunner(AbstractFileRunner):
"""JSON protocol file runner."""

def load(self) -> None:
"""Prepare to run the JSON protocol file."""
raise NotImplementedError()

def play(self) -> None:
"""Start (or un-pause) running the JSON protocol file."""
raise NotImplementedError()
Expand Down
4 changes: 0 additions & 4 deletions api/src/opentrons/file_runner/python_file_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
class PythonFileRunner(AbstractFileRunner):
"""Python protocol file runner."""

def load(self) -> None:
"""Prepare to run the Python protocol file."""
raise NotImplementedError()

def play(self) -> None:
"""Start (or un-pause) running the Python protocol file."""
raise NotImplementedError()
Expand Down
6 changes: 0 additions & 6 deletions api/tests/opentrons/file_runner/test_json_file_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ def subject() -> JsonFileRunner:
return JsonFileRunner()


@pytest.mark.xfail(raises=NotImplementedError)
def test_python_runner_load(subject: JsonFileRunner) -> None:
"""It should be able to prepare for run."""
subject.load()


@pytest.mark.xfail(raises=NotImplementedError)
def test_python_runner_play(subject: JsonFileRunner) -> None:
"""It should be able to start the run."""
Expand Down
6 changes: 0 additions & 6 deletions api/tests/opentrons/file_runner/test_python_file_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ def subject() -> PythonFileRunner:
return PythonFileRunner()


@pytest.mark.xfail(raises=NotImplementedError)
def test_python_runner_load(subject: PythonFileRunner) -> None:
"""It should be able to prepare for run."""
subject.load()


@pytest.mark.xfail(raises=NotImplementedError)
def test_python_runner_play(subject: PythonFileRunner) -> None:
"""It should be able to start the run."""
Expand Down

0 comments on commit c6667d9

Please sign in to comment.