Skip to content

Commit

Permalink
fix(app-shell-odd): fix devtools not working on built versions of the…
Browse files Browse the repository at this point in the history
… ODD
  • Loading branch information
mjhuff committed Nov 6, 2024
1 parent 3720e99 commit c42195b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion app-shell-odd/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ function installDevtools(): void {

log.debug('Installing devtools')

install(extensions, forceReinstall)
install(extensions, {
loadExtensionOptions: { allowFileAccess: true },
forceDownload: forceReinstall,
})
.then(() => log.debug('Devtools extensions installed'))
.catch((error: unknown) => {
log.warn('Failed to install devtools extensions', {
Expand Down
5 changes: 4 additions & 1 deletion app-shell/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ function installDevtools(): Promise<Logger> {
})
.then(() => log.debug('Devtools extensions installed'))
.catch((error: unknown) => {
log.warn('Failed to install devtools extensions', { error })
log.warn('Failed to install devtools extensions', {
forceReinstall,
error,
})
})
} else {
log.warn('could not resolve electron dev tools installer')
Expand Down

0 comments on commit c42195b

Please sign in to comment.