feat(protocol-designer, step-generation): multi tiprack selection per…

… pipette support closes AUTH-11, AUTH-13, AUTH-50
Opentrons · Mar 5, 2024 · bc21b8e · bc21b8e
1 parent 733a304
commit bc21b8e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/protocol-designer/cypress/integration/migrations.spec.js b/protocol-designer/cypress/integration/migrations.spec.js
@@ -46,7 +46,8 @@ describe('Protocol fixtures migrate and match snapshots', () => {
       migrationModal: 'v8',
     },
     {
-      title: '96-channel full and column schema 8 -> should migrate to 8.1.x, schema 8',
+      title:
+        '96-channel full and column schema 8 -> should migrate to 8.1.x, schema 8',
       importFixture:
         '../../fixtures/protocol/8/ninetySixChannelFullAndColumn.json',
       expectedExportFixture:
@@ -55,7 +56,8 @@ describe('Protocol fixtures migrate and match snapshots', () => {
       unusedPipettes: false,
     },
     {
-      title: 'doItAllV8 flex robot -> reimported, should migrate to 8.1.x, schema 8',
+      title:
+        'doItAllV8 flex robot -> reimported, should migrate to 8.1.x, schema 8',
       importFixture: '../../fixtures/protocol/8/doItAllV8.json',
       expectedExportFixture: '../../fixtures/protocol/8/doItAllV8.json',
       migrationModal: null,

diff --git a/protocol-designer/src/components/modals/CreateFileWizard/PipetteTipsTile.tsx b/protocol-designer/src/components/modals/CreateFileWizard/PipetteTipsTile.tsx
@@ -182,7 +182,7 @@ function PipetteTipsField(props: PipetteTipsFieldProps): JSX.Element | null {
   const selectedValues = pipettesByMount[mount].tiprackDefURI ?? []
 
   React.useEffect(() => {
-    if (selectedValues === undefined) {
+    if (selectedValues.length === 0) {
       setValue(
         `pipettesByMount.${mount}.tiprackDefURI`,
         [tiprackOptions[0]?.value] ?? ['']

diff --git a/step-generation/src/__tests__/aspirate.test.ts b/step-generation/src/__tests__/aspirate.test.ts
@@ -523,4 +523,4 @@ describe('aspirate', () => {
       type: 'HEATER_SHAKER_NORTH_SOUTH__OF_NON_TIPRACK_WITH_MULTI_CHANNEL',
     })
   })
-})
+})
diff --git a/step-generation/src/commandCreators/compound/transfer.ts b/step-generation/src/commandCreators/compound/transfer.ts
@@ -209,7 +209,7 @@ export const transfer: CommandCreator<TransferArgs> = (
   const aspirateAirGapVolume = args.aspirateAirGapVolume || 0
   const dispenseAirGapVolume = args.dispenseAirGapVolume || 0
   const effectiveTransferVol =
-  getPipetteWithTipMaxVol(args.pipette, invariantContext, tipRack) -
+    getPipetteWithTipMaxVol(args.pipette, invariantContext, tipRack) -
     aspirateAirGapVolume
   const pipetteMinVol = pipetteSpec.minVolume
   const chunksPerSubTransfer = Math.ceil(args.volume / effectiveTransferVol)
@@ -407,7 +407,6 @@ export const transfer: CommandCreator<TransferArgs> = (
                   dispenseDelaySeconds: dispenseDelay?.seconds,
                   tipRack,
                 })
-
               : []
 
           const airGapAfterAspirateCommands =

diff --git a/step-generation/src/errorCreators.ts b/step-generation/src/errorCreators.ts
@@ -262,4 +262,4 @@ export function noTipSelected(): CommandCreatorError {
     type: 'NO_TIP_SELECTED',
     message: 'No tips were selected for this step',
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -523,4 +523,4 @@ describe('aspirate', () => { @@
           type: 'HEATER_SHAKER_NORTH_SOUTH__OF_NON_TIPRACK_WITH_MULTI_CHANNEL',
         })
       })
-    })
+    })