-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(shared-data, labware-library): add deck riser definition and new…
… Lid category to LL (#16410) re AUTH-869, AUTH-892, PLAT-533, and AUTH-887 <!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> Adding a new deck riser definition with its image to shared data so it can be displayed in the Labware Library, and updating the TC lid definition to include a stacking offset for the deck riser. Also, adding a new 'Lid' category to the Labware Library for the TC auto-sealing lids. ## Test Plan and Hands on Testing - Make sure the Opentrons Flex Deck Riser shows up in the Labware Library's "Adapter" category - Ensure that the “Lid” category appears on the left navigation of the Labware Library site - When the “Lid” category is selected, the Opentrons Tough PCR Auto-Sealing Lid appears in the search results For testing deck riser definition on a Flex: - Run a protocol that have the gripper move a stack of TC lids from and to the deck riser. Example protocol I used: [deck_riser_with_tc_lid_test1.zip](https://github.com/user-attachments/files/17463215/deck_riser_with_tc_lid_test1.zip) <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> - Added the opentrons_flex_deck_riser definition to shared-data after tested it with TC lids on the Flex - Updated the opentrons_tough_pcr_auto_sealing_lid definition and added its image to LL - Updated files to include a 'Lid' category in LL ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. --> --------- Co-authored-by: shiyaochen <[email protected]>
- Loading branch information
Showing
13 changed files
with
81 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
shared-data/labware/definitions/2/opentrons_flex_deck_riser/1.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"ordering": [], | ||
"brand": { | ||
"brand": "Opentrons", | ||
"brandId": [] | ||
}, | ||
"metadata": { | ||
"displayName": "Opentrons Flex Deck Riser", | ||
"displayCategory": "adapter", | ||
"displayVolumeUnits": "\u00b5L", | ||
"tags": [] | ||
}, | ||
"dimensions": { | ||
"xDimension": 140, | ||
"yDimension": 98, | ||
"zDimension": 21 | ||
}, | ||
"wells": {}, | ||
"groups": [ | ||
{ | ||
"metadata": {}, | ||
"wells": [] | ||
} | ||
], | ||
"parameters": { | ||
"format": "96Standard", | ||
"quirks": [], | ||
"isTiprack": false, | ||
"isMagneticModuleCompatible": false, | ||
"loadName": "opentrons_flex_deck_riser" | ||
}, | ||
"namespace": "opentrons", | ||
"version": 1, | ||
"schemaVersion": 2, | ||
"allowedRoles": ["adapter"], | ||
"cornerOffsetFromSlot": { | ||
"x": 0, | ||
"y": 0, | ||
"z": 0 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,8 @@ | |
"wellPlate", | ||
"aluminumBlock", | ||
"adapter", | ||
"other" | ||
"other", | ||
"lid" | ||
] | ||
}, | ||
"safeString": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters