Skip to content

Commit

Permalink
Leave a todo for removing the old ThreadAsyncQueue.
Browse files Browse the repository at this point in the history
  • Loading branch information
SyntaxColoring committed Mar 25, 2024
1 parent 10b3372 commit b5c54af
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions api/src/opentrons/protocol_runner/legacy_context_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ def __init__(
# So if the protocol had to wait for the event loop to be free
# every time it reported some activity,
# it could visibly stall for a moment, making its motion jittery.
#
# TODO(mm, 2024-03-22): See if we can remove this non-blockingness now.
# It was one of several band-aids introduced in ~v5.0.0 to mitigate performance
# problems. v6.3.0 started running some Python protocols directly through
# Protocol Engine, without this plugin, and without any non-blocking queue.
# If performance is sufficient for those, that probably means the
# performance problems have been resolved in better ways elsewhere
# and we don't need this anymore.
self._actions_to_dispatch = ThreadAsyncQueue[List[pe_actions.Action]]()
self._action_dispatching_task: Optional[Task[None]] = None

Expand Down

0 comments on commit b5c54af

Please sign in to comment.