update naming convention for analytics consts

Opentrons · Feb 6, 2024 · ac882a0 · ac882a0
1 parent a770ed5
commit ac882a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app/src/pages/EmergencyStop/index.tsx b/app/src/pages/EmergencyStop/index.tsx
@@ -31,8 +31,8 @@ const ESTOP_STATUS_REFETCH_INTERVAL_MS = 10000
 export function EmergencyStop(): JSX.Element {
   const { i18n, t } = useTranslation(['device_settings', 'shared'])
   const history = useHistory()
-  const seen = useSelector(getAnalyticsOptInSeen)
-  const hasOptedIn = useSelector(getAnalyticsOptedIn)
+  const seenOptIn = useSelector(getAnalyticsOptInSeen)
+  const optedIn = useSelector(getAnalyticsOptedIn)
 
   // Note here the touchscreen app is using status since status is linked to EstopPhysicalStatuses
   // left notPresent + right disengaged => disengaged
@@ -106,7 +106,7 @@ export function EmergencyStop(): JSX.Element {
           buttonText={i18n.format(t('shared:continue'), 'capitalize')}
           disabled={!isEstopConnected}
           onClick={() => {
-            seen && hasOptedIn
+            seenOptIn && optedIn
               ? history.push('/robot-settings/rename-robot')
               : history.push('/privacy-policy')
           }}

diff --git a/app/src/pages/PrivacyPolicy/index.tsx b/app/src/pages/PrivacyPolicy/index.tsx
@@ -35,23 +35,23 @@ export function PrivacyPolicy(): JSX.Element {
   const history = useHistory()
   const dispatch = useDispatch<Dispatch>()
   const isUnboxingFlowOngoing = useIsUnboxingFlowOngoing()
-  const hasOptedIn = useSelector(getAnalyticsOptedIn)
-  const seen = useSelector(getAnalyticsOptInSeen)
+  const seenOptedIn = useSelector(getAnalyticsOptInSeen)
+  const optedIn = useSelector(getAnalyticsOptedIn)
 
   const handleAgree = (): void => {
     dispatch(setAnalyticsOptInSeen())
     dispatch(toggleAnalyticsOptedIn())
   }
 
   React.useEffect(() => {
-    if (hasOptedIn && seen) {
+    if (seenOptedIn && optedIn) {
       if (isUnboxingFlowOngoing) {
         history.push('/robot-settings/rename-robot')
       } else {
         history.push('/dashboard')
       }
     }
-  }, [hasOptedIn, seen])
+  }, [seenOptedIn, optedIn])
 
   return (
     <>