address feedback and fix lint

Opentrons · Mar 13, 2024 · aa8f55b · aa8f55b
1 parent 89d8b7c
commit aa8f55b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 23 deletions.
diff --git a/app/src/atoms/Slideout/MultiSlideout.stories.tsx b/app/src/atoms/Slideout/MultiSlideout.stories.tsx
@@ -14,16 +14,13 @@ export default {
 const Template: Story<React.ComponentProps<typeof MultiSlideout>> = args => {
   const [firstPage, setFirstPage] = React.useState<boolean>(false)
 
-  const togglePage = () => {
+  const togglePage = (): void => {
     setFirstPage(prevState => !prevState)
   }
 
-  const Children = (
-    <React.Fragment>
-      <StyledText
-        fontWeight={TYPOGRAPHY.fontWeightSemiBold}
-        fontSize={TYPOGRAPHY.fontSizeP}
-      >
+  const children = (
+    <>
+      <StyledText as="p">
         {firstPage ? 'first page body' : 'second page body'}
       </StyledText>
 
@@ -33,22 +30,17 @@ const Template: Story<React.ComponentProps<typeof MultiSlideout>> = args => {
         backgroundColor={COLORS.blue50}
         textTransform={TYPOGRAPHY.textTransformNone}
       >
-        <StyledText
-          fontWeight={TYPOGRAPHY.fontWeightRegular}
-          fontSize={TYPOGRAPHY.fontSizeP}
-        >
+        <StyledText as="p">
           {firstPage ? 'Go to Second Page' : 'Go to First Page'}
         </StyledText>
       </PrimaryBtn>
-    </React.Fragment>
+    </>
   )
 
   return (
-    <MultiSlideout
-      {...args}
-      children={Children}
-      currentStep={firstPage ? 1 : 2}
-    />
+    <MultiSlideout {...args} currentStep={firstPage ? 1 : 2}>
+      {children}
+    </MultiSlideout>
   )
 }
 

diff --git a/app/src/atoms/Slideout/index.tsx b/app/src/atoms/Slideout/index.tsx
@@ -179,7 +179,7 @@ export const Slideout = (props: SlideoutProps): JSX.Element => {
           flexDirection={DIRECTION_COLUMN}
           justifyContent={JUSTIFY_SPACE_BETWEEN}
         >
-          {multiSlideoutSpecs == null ? null : (
+          {multiSlideoutSpecs === undefined ? null : (
             <StyledText
               as="p"
               color={COLORS.grey60}

diff --git a/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx b/app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx
@@ -8,7 +8,6 @@ import {
   Icon,
   Flex,
   DIRECTION_COLUMN,
-  SIZE_1,
   PrimaryButton,
   DIRECTION_ROW,
   SecondaryButton,
@@ -145,7 +144,7 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
       ? mostRecentAnalysis?.robotType ?? null
       : null
 
-  const singlePageButtonWithoutFF = (
+  const SinglePageButtonWithoutFF = (
     <PrimaryButton
       disabled={
         isCreatingRun ||
@@ -156,7 +155,7 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
       onClick={handleProceed}
     >
       {isCreatingRun ? (
-        <Icon name="ot-spinner" spin size={SIZE_1} />
+        <Icon name="ot-spinner" spin size="1rem" />
       ) : (
         t('shared:proceed_to_setup')
       )}
@@ -206,15 +205,15 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
                 </SecondaryButton>
                 <PrimaryButton width="50%" onClick={handleProceed}>
                   {isCreatingRun ? (
-                    <Icon name="ot-spinner" spin size={SIZE_1} />
+                    <Icon name="ot-spinner" spin size="1rem" />
                   ) : (
                     t('shared:confirm_values')
                   )}
                 </PrimaryButton>
               </Flex>
             )
           ) : (
-            singlePageButtonWithoutFF
+            SinglePageButtonWithoutFF
           )}
         </Flex>
       }