-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(api): add liquid classes to the StateSummary. (#16899)
# Overview AUTH-851 Export the liquid classes we loaded into the Protocol Engine to the `StateSummary`, which will let clients see what liquid classes we loaded. The liquid classes are stored internally as a map of `{liquid_class_id -> LiquidClassRecords}`, but following the convention for the other fields in the `StateSummary`, we want to export the liquid classes as a list, so this PR defines a new `LiquidClassRecordWithId` class for the summary. The fields in the `StateSummary` in turn are propagated to the CLI `AnalyzeResults`, and are mirrored to the robot-server `CompletedAnalysis`, `Run`, and `MaintenanceRun` models. So every call-site that uses those classes had to be updated, as well as every test that checks those classes, as well as 200 snapshot tests -- which was kind of painful. ## Test Plan and Hands on Testing I'm relying on the CI tests to make sure I found all the call-sites that are affected. (We don't yet have any protocols that load liquid classes, but when we do, we can probably add integration tests to show that the liquid classes end up in the summaries.) ## Review requests I recommend collapsing the `analyses-snapshot-testing/` when looking at this PR in Github. There are so many snapshot changes that Github sometimes errors out when trying to render the diff. The primary files with code changes are: - `api/src/opentrons/protocol_engine/types.py` - `api/src/opentrons/protocol_engine/state/state.py` - `api/src/opentrons/protocol_engine/state/state_summary.py` - `api/src/opentrons/cli/analyze.py` - `robot-server/robot_server/runs/run_models.py` - `robot-server/robot_server/protocols/analysis_models.py` - `robot-server/robot_server/maintenance_runs/maintenance_run_models.py` The other files are pretty mechanical changes. ## Risk assessment Low risk, should affect dev only. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: y3rsh <[email protected]>
- Loading branch information
1 parent
ecd916b
commit a910cf0
Showing
251 changed files
with
331 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16668,6 +16668,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"apiLevel": "2.11" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4919,6 +4919,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"apiLevel": "2.7", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11824,6 +11824,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "<[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11452,6 +11452,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "High Quality H₂O", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2917,6 +2917,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "H₂O", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3113,6 +3113,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Opentrons Engineering <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9569,6 +9569,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Opentrons Engineering <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66156,6 +66156,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Opentrons <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1481,6 +1481,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,6 +154,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": {}, | ||
"modules": [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49707,6 +49707,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "CleanupBead Beads", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1481,6 +1481,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17072,6 +17072,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "H₂O", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9569,6 +9569,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Opentrons Engineering <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49392,6 +49392,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Beads", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33697,6 +33697,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": {}, | ||
"modules": [], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7997,6 +7997,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6203,6 +6203,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "water for ER testing", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4492,6 +4492,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Dandra Howell <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34590,6 +34590,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Beads", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9297,6 +9297,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"author": "Rami Farawi <[email protected]", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1481,6 +1481,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12753,6 +12753,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53267,6 +53267,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Dynebeads Slurry", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82175,6 +82175,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"apiLevel": "2.4", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20891,6 +20891,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "DNAse", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31929,6 +31929,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Dilution Buffer", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35213,6 +35213,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "AL Buffer", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26205,6 +26205,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": " ", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2728,6 +2728,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56906,6 +56906,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Sample per well", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17669,6 +17669,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Samples", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20878,6 +20878,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "Samples", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3912,6 +3912,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3878,6 +3878,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4241,6 +4241,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": {}, | ||
"modules": [], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31816,6 +31816,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "DB1/DP1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1481,6 +1481,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"description": "oooo", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1607,6 +1607,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [], | ||
"metadata": { | ||
"apiLevel": "2.2" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16660,6 +16660,7 @@ | |
} | ||
} | ||
], | ||
"liquidClasses": [], | ||
"liquids": [ | ||
{ | ||
"description": "DNA Fragments to be Inserted", | ||
|
Oops, something went wrong.