Skip to content

Commit

Permalink
feat(app): add runtime parameters feature flag (#14643)
Browse files Browse the repository at this point in the history
* feat(app): add runtime parameters feature flag
  • Loading branch information
koji authored and Carlos-fernandez committed May 20, 2024
1 parent 500c529 commit 9e0f56e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/src/assets/localization/en/app_settings.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"__dev_internal__protocolStats": "Protocol Stats",
"__dev_internal__enableRunTimeParameters": "Enable Run Time Parameters",
"add_folder_button": "Add labware source folder",
"add_ip_button": "Add",
"add_ip_error": "Enter an IP Address or Hostname",
Expand Down
5 changes: 4 additions & 1 deletion app/src/redux/config/constants.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import type { DevInternalFlag } from './types'

export const DEV_INTERNAL_FLAGS: DevInternalFlag[] = ['protocolStats']
export const DEV_INTERNAL_FLAGS: DevInternalFlag[] = [
'protocolStats',
'enableRunTimeParameters',
]

// action type constants
export const INITIALIZED: 'config:INITIALIZED' = 'config:INITIALIZED'
Expand Down
2 changes: 1 addition & 1 deletion app/src/redux/config/schema-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type UpdateChannel = 'latest' | 'beta' | 'alpha'

export type DiscoveryCandidates = string[]

export type DevInternalFlag = 'protocolStats'
export type DevInternalFlag = 'protocolStats' | 'enableRunTimeParameters'

export type FeatureFlags = Partial<Record<DevInternalFlag, boolean | undefined>>

Expand Down

0 comments on commit 9e0f56e

Please sign in to comment.