Skip to content

Commit

Permalink
fix(app): filter robots for CSV protocols that raise analysis errors (#…
Browse files Browse the repository at this point in the history
…16145)

We are intentionally permissive of robots on which to start protocol
setup if analysis fails app-side. However, we previously checked whether
the analysis contained errors to make this determination. Given that CSV
parameter protocols raise analysis errors intentionally, but contain
useful information regarding the robot type, we should filter robots if
the analysis result is `parameter-value-required`.

Closes RQA-3114
  • Loading branch information
ncdiehl11 authored Aug 27, 2024
1 parent f5e3317 commit 95a656f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
first(srcFileNames) ??
protocolKey

// intentionally show both robot types if analysis has any error
// intentionally show both robot types if analysis fails
const robotType =
mostRecentAnalysis != null && mostRecentAnalysis.errors.length === 0
mostRecentAnalysis != null && mostRecentAnalysis.result !== 'not-ok'
? mostRecentAnalysis?.robotType ?? null
: null

Expand Down

0 comments on commit 95a656f

Please sign in to comment.