Skip to content

Commit

Permalink
chore(shared-data): Add some more geometry defs (#16669)
Browse files Browse the repository at this point in the history
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
Some of the missing ones were just labware that we had two load names
for.
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
  • Loading branch information
ryanthecoder authored Nov 1, 2024
1 parent 20f1f87 commit 917f8f2
Show file tree
Hide file tree
Showing 4 changed files with 121 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,28 @@
],
"innerLabwareGeometry": {
"conicalWell": {
"sections": []
"sections": [
{
"shape": "spherical",
"radiusOfCurvature": 1.25,
"topHeight": 0.8,
"bottomHeight": 0.0
},
{
"shape": "conical",
"topDiameter": 5.5,
"bottomDiameter": 2.33,
"topHeight": 11.35,
"bottomHeight": 0.8
},
{
"shape": "conical",
"bottomDiameter": 5.5,
"topDiameter": 5.5,
"topHeight": 14.95,
"bottomHeight": 11.35
}
]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"x": 13.88,
"y": 67.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"B1": {
"totalLiquidVolume": 15000,
Expand All @@ -44,7 +44,7 @@
"x": 13.88,
"y": 42.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"C1": {
"totalLiquidVolume": 15000,
Expand All @@ -54,7 +54,7 @@
"x": 13.88,
"y": 17.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"A2": {
"totalLiquidVolume": 15000,
Expand All @@ -64,7 +64,7 @@
"x": 38.88,
"y": 67.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"B2": {
"totalLiquidVolume": 15000,
Expand All @@ -74,7 +74,7 @@
"x": 38.88,
"y": 42.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"C2": {
"totalLiquidVolume": 15000,
Expand All @@ -84,7 +84,7 @@
"x": 38.88,
"y": 17.75,
"z": 6.85,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"A3": {
"totalLiquidVolume": 50000,
Expand All @@ -94,7 +94,7 @@
"x": 71.38,
"y": 60.25,
"z": 7.3,
"geometryDefinitionId": "b"
"geometryDefinitionId": "50mlconicalWell"
},
"B3": {
"totalLiquidVolume": 50000,
Expand All @@ -104,7 +104,7 @@
"x": 71.38,
"y": 25.25,
"z": 7.3,
"geometryDefinitionId": "b"
"geometryDefinitionId": "50mlconicalWell"
},
"A4": {
"totalLiquidVolume": 50000,
Expand All @@ -114,7 +114,7 @@
"x": 106.38,
"y": 60.25,
"z": 7.3,
"geometryDefinitionId": "b"
"geometryDefinitionId": "50mlconicalWell"
},
"B4": {
"totalLiquidVolume": 50000,
Expand All @@ -124,7 +124,7 @@
"x": 106.38,
"y": 25.25,
"z": 7.3,
"geometryDefinitionId": "b"
"geometryDefinitionId": "50mlconicalWell"
}
},
"brand": {
Expand Down Expand Up @@ -172,7 +172,7 @@
"z": 0
},
"innerLabwareGeometry": {
"conicalWell": {
"15mlconicalWell": {
"sections": [
{
"shape": "spherical",
Expand Down Expand Up @@ -203,7 +203,7 @@
}
]
},
"b": {
"50mlconicalWell": {
"sections": [
{
"shape": "conical",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"x": 19,
"y": 74,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"B1": {
"totalLiquidVolume": 15000,
Expand All @@ -18,7 +18,7 @@
"x": 19,
"y": 42.5,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"C1": {
"totalLiquidVolume": 15000,
Expand All @@ -28,7 +28,7 @@
"x": 19,
"y": 11,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"A2": {
"totalLiquidVolume": 15000,
Expand All @@ -38,7 +38,7 @@
"x": 42,
"y": 74,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"B2": {
"totalLiquidVolume": 15000,
Expand All @@ -48,7 +48,7 @@
"x": 42,
"y": 42.5,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"C2": {
"totalLiquidVolume": 15000,
Expand All @@ -58,7 +58,7 @@
"x": 42,
"y": 11,
"z": 5.78,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "15mlconicalWell"
},
"A3": {
"totalLiquidVolume": 50000,
Expand All @@ -68,7 +68,7 @@
"x": 70.2,
"y": 62.2,
"z": 5.95,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "50mlconicalWell"
},
"B3": {
"totalLiquidVolume": 50000,
Expand All @@ -78,7 +78,7 @@
"x": 70.2,
"y": 16.8,
"z": 5.95,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "50mlconicalWell"
},
"A4": {
"totalLiquidVolume": 50000,
Expand All @@ -88,7 +88,7 @@
"x": 106.1,
"y": 62.2,
"z": 5.95,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "50mlconicalWell"
},
"B4": {
"totalLiquidVolume": 50000,
Expand All @@ -98,7 +98,7 @@
"x": 106.1,
"y": 16.8,
"z": 5.95,
"geometryDefinitionId": "conicalWell"
"geometryDefinitionId": "50mlconicalWell"
}
},
"brand": {
Expand Down Expand Up @@ -170,8 +170,61 @@
"z": 0
},
"innerLabwareGeometry": {
"conicalWell": {
"sections": []
"15mlconicalWell": {
"sections": [
{
"shape": "spherical",
"radiusOfCurvature": 2.9,
"topHeight": 0.8,
"bottomHeight": 0.0
},
{
"shape": "conical",
"bottomDiameter": 4,
"topDiameter": 13.5,
"topHeight": 20.7,
"bottomHeight": 0.8
},
{
"shape": "conical",
"bottomDiameter": 13.5,
"topDiameter": 14.5,
"topHeight": 108.6,
"bottomHeight": 20.7
},
{
"shape": "conical",
"bottomDiameter": 14.5,
"topDiameter": 14.7,
"topHeight": 118.2,
"bottomHeight": 108.6
}
]
},
"50mlconicalWell": {
"sections": [
{
"shape": "conical",
"bottomDiameter": 6.15,
"topDiameter": 26.18,
"topHeight": 14.3,
"bottomHeight": 0.0
},
{
"shape": "conical",
"bottomDiameter": 26.18,
"topDiameter": 27.52,
"topHeight": 100.65,
"bottomHeight": 14.3
},
{
"shape": "conical",
"bottomDiameter": 27.52,
"topDiameter": 27.81,
"topHeight": 112.85,
"bottomHeight": 100.65
}
]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,28 @@
],
"innerLabwareGeometry": {
"conicalWell": {
"sections": []
"sections": [
{
"shape": "spherical",
"radiusOfCurvature": 1.25,
"topHeight": 0.8,
"bottomHeight": 0.0
},
{
"shape": "conical",
"topDiameter": 5.5,
"bottomDiameter": 2.33,
"topHeight": 11.35,
"bottomHeight": 0.8
},
{
"shape": "conical",
"bottomDiameter": 5.5,
"topDiameter": 5.5,
"topHeight": 14.95,
"bottomHeight": 11.35
}
]
}
}
}

0 comments on commit 917f8f2

Please sign in to comment.