Skip to content

Commit

Permalink
fix(api): Correct well ordering for custom labware (#2633)
Browse files Browse the repository at this point in the history
Fixes #2631
  • Loading branch information
btmorr authored Nov 5, 2018
1 parent 8e40b29 commit 8e7530c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions api/src/opentrons/legacy_api/containers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ def create(name, grid, spacing, diameter, depth, volume=0):
'total-liquid-volume': volume
}

for r in range(rows):
for c in range(columns):
for c in range(columns):
for r in range(rows):
well = Well(properties=properties)
well_name = chr(r + ord('A')) + str(1 + c)
coordinates = (c * col_spacing, (rows - r - 1) * row_spacing, 0)
Expand Down
2 changes: 2 additions & 0 deletions api/tests/opentrons/database/test_labware_definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ def test_labware_create(dummy_db):
assert lw.well("C3").coordinates() == (
2 * col_space, 0, 0)

assert lw.well(2).get_name() == 'C1'


def test_new_labware_create(split_labware_def):
from opentrons import labware
Expand Down

0 comments on commit 8e7530c

Please sign in to comment.