build(node): upgrade dev setup to Node v12

Opentrons · Sep 20, 2019 · 89bb49b · 89bb49b
1 parent 33a4012
commit 89bb49b
Show file tree

Hide file tree

Showing 6 changed files with 418 additions and 949 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-8
+12
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -148,10 +148,10 @@ Your computer will need the following tools installed to be able to develop with
   pyenv install 3.6.4
   ```
 
-- Node v8 LTS (Carbon) - [nvm][] is optional, but recommended
+- Node v12 - [nvm][] is optional, but recommended
 
   ```shell
-  nvm install lts/carbon
+  nvm install 12
   ```
 
 - [yarn][yarn-install] - JavaScript package manager

diff --git a/appveyor.yml b/appveyor.yml
@@ -33,7 +33,7 @@ cache:
 
 install:
   # read node version from the first line of .nvmrc
-  - ps: $env:nodejs_version = (Get-Content -Path .nvmrc)[0]
+  - ps: $env:nodejs_version = Get-Content -Path .nvmrc
   - ps: Install-Product node $env:nodejs_version x64
   # install dev dependencies
   - cmd: '%MAKE% -j 2 install'

diff --git a/components/README.md b/components/README.md
@@ -18,7 +18,7 @@ export default function CowButton(props) {
 
 Usage requirements for dependent projects:
 
-- Node lts/carbon (v8) and yarn
+- Node v12 and yarn
 - The following `dependencies` (peer dependencies of `@opentrons/components`)
   - `react`: `^16.8.6`,
   - `react-router-dom`: `^4.2.2`,

diff --git a/package.json b/package.json
@@ -20,6 +20,9 @@
       "path": "cz-conventional-changelog"
     }
   },
+  "engines": {
+    "node": ">=12"
+  },
   "devDependencies": {
     "@babel/cli": "^7.6.0",
     "@babel/core": "^7.6.0",
@@ -112,6 +115,9 @@
     "webpack-dev-server": "^3.8.1",
     "webpack-merge": "^4.2.2",
     "worker-loader": "^2.0.0",
-    "ws": "3.1.0"
+    "ws": "7.1.2"
+  },
+  "resolutions": {
+    "watchpack": "^2.0.0-beta.7"
   }
 }