-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(api): redefine well geometry structure (#16392)
## Overview After discovering some new shapes and generally interacting with the new well geometry data structures, I think it would be better to reshape the geometry data a little bit. Rather than having each section of a well be represented by its top cross-section and top height, let's just represent a section in its entirety, with bottom and top cross-sections and bottom and top heights being present in every shape that is not a `SphericalSegment`. ## Changelog - add `RoundedRectangle` class - add `TruncatedCircle` class - add `CircularFrustum` and `RectangularFrustum` classes - adjust `frustum_helpers` and tests to use the new data structure ## TODO - We should [write some more tests](https://opentrons.atlassian.net/browse/EXEC-743?atlOrigin=eyJpIjoiYzg5OThhMjQ2NTViNDRmNGI2OTkwMWEwYTExMmFjNjIiLCJwIjoiaiJ9) to make sure invalid wells don't get passed in without an error being raised. - Implement the math for [truncated circle](https://opentrons.atlassian.net/browse/EXEC-712) calculations - Implement the math for [rounded rectangle](https://opentrons.atlassian.net/browse/EXEC-744) calculations --------- Co-authored-by: Ryan howard <[email protected]>
- Loading branch information
1 parent
50d3208
commit 7f6506f
Showing
12 changed files
with
790 additions
and
463 deletions.
There are no files selected for viewing
376 changes: 159 additions & 217 deletions
376
api/src/opentrons/protocol_engine/state/frustum_helpers.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.