Skip to content

Commit

Permalink
refactor(app): add more information on xy jog (#6931)
Browse files Browse the repository at this point in the history
In user testing, it's not entirely clear why you would want to enable xy
jog when jogging to the deck, or where you would want to jog to. This
adds more information.
  • Loading branch information
sfoster1 authored Nov 5, 2020
1 parent 97ac044 commit 7dec936
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 6 additions & 2 deletions app/src/components/CalibrationPanels/SaveZPoint.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ const TO_USE_Z =
'button to use this z position for the rest of deck calibration'
const CALIBRATION_HEALTH_TO_DETERMINE =
'button to determine how this position compares to the previously saved z-axis calibration coordinate'
const ALLOW_HORIZONTAL_TEXT =
'Need to jog across the deck to align the pipette in slot 5?'
const ALLOW_HORIZONTAL_TEXT = 'Reveal XY jog controls to move across deck'
const ALLOW_XY_JOG_INSTRUCTIONS =
'If the pipette is over the embossed 5, on the ridge of the slot, or hard to see, reveal the jog controls to move the pipette across the deck.'

const contentsBySessionType: {
[SessionType]: {
Expand Down Expand Up @@ -180,6 +181,9 @@ export function SaveZPoint(props: CalibrationPanelProps): React.Node {
{THEN}
<b>{` '${buttonText}' `}</b>
{isHealthCheck ? CALIBRATION_HEALTH_TO_DETERMINE : TO_USE_Z}.
<br />
<br />
{ALLOW_XY_JOG_INSTRUCTIONS}
</Text>
<video
key={demoAsset}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,7 @@ describe('SaveZPoint', () => {
expect(getJogButton(wrapper, dir).exists()).toBe(false)
})
wrapper
.find(
'button[children="Need to jog across the deck to align the pipette in slot 5?"]'
)
.find('button[children="Reveal XY jog controls to move across deck"]')
.invoke('onClick')({ preventDefault: () => {} })
jogDirections.forEach(direction => {
getJogButton(wrapper, direction).invoke('onClick')()
Expand Down

0 comments on commit 7dec936

Please sign in to comment.