Skip to content

Commit

Permalink
fix(opentrons-ai-client): Fixed footer text size and spinner not rese…
Browse files Browse the repository at this point in the history
…tting back to initializing (#16827)

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Fixed the size of the Opentrons may make mistake disclaimer to be
smaller and reset the spinner to Initializing after it is done being
called.

<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
  • Loading branch information
connected-znaim authored Nov 14, 2024
1 parent d56f5c7 commit 63f8b8e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion opentrons-ai-client/src/atoms/SendButton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ export function SendButton({
if (newIndex > progressTexts.length - 1) {
newIndex = progressTexts.length - 1
}
setButtonText(progressTexts[newIndex])
return newIndex
})
}, 10000)

return () => {
setProgressIndex(0)
setButtonText(progressTexts[0])
clearInterval(interval)
}
}
Expand Down
2 changes: 1 addition & 1 deletion opentrons-ai-client/src/molecules/ChatFooter/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function ChatFooter(): JSX.Element {

const DISCLAIMER_TEXT_STYLE = css`
color: ${COLORS.grey55};
font-size: ${TYPOGRAPHY.fontSize20};
font-size: ${TYPOGRAPHY.fontSizeH3};
line-height: ${TYPOGRAPHY.lineHeight24};
text-align: ${TYPOGRAPHY.textAlignCenter};
`

0 comments on commit 63f8b8e

Please sign in to comment.