fix(app): fix flickering "stand back" screen during gripper error rec…

…overy
Opentrons · Nov 1, 2024 · 602837b · 602837b
1 parent a6bd20a
commit 602837b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...oks/__tests__/useHomeGripperZAxis.test.ts → ...ws/hooks/__tests__/useHomeGripper.test.ts b/...oks/__tests__/useHomeGripperZAxis.test.ts → ...ws/hooks/__tests__/useHomeGripper.test.ts
@@ -94,7 +94,7 @@ describe('useHomeGripper', () => {
     ).toHaveBeenCalledTimes(1)
   })
 
-  it('should reset hasHomedOnce when step changes to non-manual gripper step and back', async () => {
+  it('should only reset hasHomedOnce when step changes to non-manual gripper step', async () => {
     const { rerender } = renderHook(
       ({ recoveryMap }) => {
         useHomeGripper({
@@ -123,6 +123,10 @@ describe('useHomeGripper', () => {
       await new Promise(resolve => setTimeout(resolve, 0))
     })
 
+    expect(
+      mockRecoveryCommands.updatePositionEstimatorsAndHomeGripper
+    ).toHaveBeenCalledTimes(1)
+
     rerender({ recoveryMap: mockRecoveryMap })
 
     await act(async () => {

diff --git a/app/src/organisms/ErrorRecoveryFlows/hooks/useHomeGripper.ts b/app/src/organisms/ErrorRecoveryFlows/hooks/useHomeGripper.ts
@@ -29,14 +29,14 @@ export function useHomeGripper({
         } else {
           void handleMotionRouting(true)
             .then(() => updatePositionEstimatorsAndHomeGripper())
-            .then(() => {
+            .finally(() => {
+              handleMotionRouting(false)
               setHasHomedOnce(true)
             })
-            .finally(() => handleMotionRouting(false))
         }
       }
     } else {
-      if (!isManualGripperStep) {
+      if (!isManualGripperStep && hasHomedOnce) {
         setHasHomedOnce(false)
       }
     }