remove size from EmptySelectorButton

Opentrons · Sep 27, 2024 · 4e8d1f0 · 4e8d1f0
1 parent 1847b66
commit 4e8d1f0
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 29 deletions.
diff --git a/components/src/atoms/buttons/EmptySelectorButton.stories.tsx b/components/src/atoms/buttons/EmptySelectorButton.stories.tsx
@@ -6,13 +6,6 @@ const meta: Meta<typeof EmptySelectorButtonComponent> = {
   title: 'Library/Atoms/Buttons/EmptySelectorButton',
   component: EmptySelectorButtonComponent,
   argTypes: {
-    size: {
-      control: {
-        type: 'select',
-        options: ['large', 'small'],
-      },
-      defaultValue: 'large',
-    },
     textAlignment: {
       controls: {
         type: 'select',
@@ -37,7 +30,6 @@ export const EmptySelectorButton: Story = {
   args: {
     text: 'mock text',
     iconName: 'plus',
-    size: 'small',
     textAlignment: 'left',
     onClick: () => {},
   },

diff --git a/components/src/atoms/buttons/EmptySelectorButton.tsx b/components/src/atoms/buttons/EmptySelectorButton.tsx
@@ -20,28 +20,19 @@ interface EmptySelectorButtonProps {
   text: string
   textAlignment: 'left' | 'middle'
   iconName?: IconName
-  size?: 'large' | 'small'
   disabled?: boolean
 }
 
 //  used for helix and Opentrons Ai
 export function EmptySelectorButton(
   props: EmptySelectorButtonProps
 ): JSX.Element {
-  const {
-    onClick,
-    text,
-    iconName,
-    size = 'large',
-    textAlignment,
-    disabled = false,
-  } = props
-  const buttonSizing = size === 'large' ? '100%' : FLEX_MAX_CONTENT
+  const { onClick, text, iconName, textAlignment, disabled = false } = props
 
   const StyledButton = styled.button`
     border: none;
     width: ${FLEX_MAX_CONTENT};
-    height: ${buttonSizing};
+    height: ${FLEX_MAX_CONTENT};
     cursor: ${disabled ? CURSOR_DEFAULT : CURSOR_POINTER};
     &:focus-visible {
       outline: 2px solid ${COLORS.white};

diff --git a/components/src/atoms/buttons/__tests__/EmptySelectorButton.test.tsx b/components/src/atoms/buttons/__tests__/EmptySelectorButton.test.tsx
@@ -18,7 +18,6 @@ describe('EmptySelectorButton', () => {
       text: 'mock text',
       iconName: 'add',
       textAlignment: 'left',
-      size: 'large',
     }
   })
   it('renders the props and button cta', () => {
@@ -33,7 +32,6 @@ describe('EmptySelectorButton', () => {
   })
   it('renders middled aligned button', () => {
     props.textAlignment = 'middle'
-    props.size = 'small'
     props.iconName = undefined
     render(props)
     expect(screen.getByTestId('EmptySelectorButton_container')).toHaveStyle(

diff --git a/protocol-designer/src/organisms/EditInstrumentsModal/index.tsx b/protocol-designer/src/organisms/EditInstrumentsModal/index.tsx
@@ -270,7 +270,6 @@ export function EditInstrumentsModal(
                   text={t('add_pip')}
                   textAlignment="left"
                   iconName="plus"
-                  size="large"
                 />
               )}
               {rightPip != null &&
@@ -305,7 +304,6 @@ export function EditInstrumentsModal(
                   text={t('add_pip')}
                   textAlignment="left"
                   iconName="plus"
-                  size="large"
                 />
               )}
             </Flex>
@@ -367,7 +365,6 @@ export function EditInstrumentsModal(
                     text={t('protocol_overview:add_gripper')}
                     textAlignment="left"
                     iconName="plus"
-                    size="large"
                   />
                 )}
               </Flex>

diff --git a/protocol-designer/src/pages/CreateNewProtocolWizard/SelectFixtures.tsx b/protocol-designer/src/pages/CreateNewProtocolWizard/SelectFixtures.tsx
@@ -92,7 +92,6 @@ export function SelectFixtures(props: WizardTileProps): JSX.Element | null {
                   disabled={numSlotsAvailable === 0}
                   key={equipment}
                   textAlignment={TYPOGRAPHY.textAlignLeft}
-                  size="small"
                   iconName="plus"
                   text={t(`${equipment}`)}
                   onClick={() => {

diff --git a/protocol-designer/src/pages/CreateNewProtocolWizard/SelectModules.tsx b/protocol-designer/src/pages/CreateNewProtocolWizard/SelectModules.tsx
@@ -141,7 +141,6 @@ export function SelectModules(props: WizardTileProps): JSX.Element | null {
                         numMagneticBlocks === 4)
                     }
                     textAlignment={TYPOGRAPHY.textAlignLeft}
-                    size="small"
                     iconName="plus"
                     text={getModuleDisplayName(moduleModel)}
                     onClick={() => {

diff --git a/protocol-designer/src/pages/CreateNewProtocolWizard/SelectPipettes.tsx b/protocol-designer/src/pages/CreateNewProtocolWizard/SelectPipettes.tsx
@@ -448,7 +448,6 @@ export function SelectPipettes(props: WizardTileProps): JSX.Element | null {
                     text={t('add_pip')}
                     textAlignment="left"
                     iconName="plus"
-                    size="large"
                   />
                 )}
                 {pipettesByMount.right.pipetteName != null &&
@@ -480,7 +479,6 @@ export function SelectPipettes(props: WizardTileProps): JSX.Element | null {
                     text={t('add_pip')}
                     textAlignment="left"
                     iconName="plus"
-                    size="large"
                   />
                 )}
               </Flex>

diff --git a/protocol-designer/src/pages/Designer/Offdeck/OffDeckDetails.tsx b/protocol-designer/src/pages/Designer/Offdeck/OffDeckDetails.tsx
@@ -152,7 +152,6 @@ export function OffDeckDetails(props: OffDeckDetailsProps): JSX.Element {
                 onClick={addLabware}
                 text={t('add_labware')}
                 textAlignment="middle"
-                size="large"
                 iconName="plus"
               />
             </Flex>