added comments

Opentrons · Oct 23, 2024 · 4a36e9a · 4a36e9a
1 parent 5bafa09
commit 4a36e9a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/api/src/opentrons/protocol_api/instrument_context.py b/api/src/opentrons/protocol_api/instrument_context.py
@@ -765,7 +765,7 @@ def air_gap(
             raise RuntimeError("No previous Well cached to perform air gap")
         target = loc.labware.as_well().top(height)
         self.move_to(target, publish=False)
-        self.aspirate(volume)
+        self.aspirate(volume) # add (is_liquid: bool = True) parameter to aspirate? Or deduce location is not in well in Aspirate command?
         return self
 
     @publisher.publish(command=cmds.return_tip)

diff --git a/api/src/opentrons/protocol_engine/commands/blow_out.py b/api/src/opentrons/protocol_engine/commands/blow_out.py
@@ -93,6 +93,7 @@ async def execute(self, params: BlowOutParams) -> _ExecuteReturn:
                 pipette_id=params.pipetteId, flow_rate=params.flowRate
             )
         except PipetteOverpressureError as e:
+            # can we get blown_out_amount_prior_to_error? If not, can we assume no liquid was added to well? Ask Ryan
             return DefinedErrorData(
                 public=OverpressureError(
                     id=self._model_utils.generate_id(),
@@ -114,6 +115,7 @@ async def execute(self, params: BlowOutParams) -> _ExecuteReturn:
                 ),
             )
         else:
+            # if blow out over a well, can we get pipette tip liquid volume and add that to well liquid volume?
             return SuccessData(
                 public=BlowOutResult(position=deck_point),
                 private=None,

diff --git a/api/src/opentrons/protocol_engine/commands/dispense.py b/api/src/opentrons/protocol_engine/commands/dispense.py
@@ -107,7 +107,7 @@ async def execute(self, params: DispenseParams) -> _ExecuteReturn:
                 push_out=params.pushOut,
             )
         except PipetteOverpressureError as e:
-            # can we get aspirated_amount_prior_to_error? If not, can we assume no liquid was removed from well? Ask Ryan
+            # can we get dispensed_amount_prior_to_error? If not, can we assume no liquid was added to well? Ask Ryan
             return DefinedErrorData(
                 public=OverpressureError(
                     id=self._model_utils.generate_id(),