Skip to content

Commit

Permalink
fix(opentrons-ai-client): Made the Application and Description start …
Browse files Browse the repository at this point in the history
…on a new line for the crea… (#16844)

Made the Application and Description start on a new line for the create
new protocol prompt when displayed on the chat page

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

BEFORE: 
Pipette mount list text is too large
And description and application text starts right after the : instead of
on a new line
<img width="1048" alt="image"
src="https://github.com/user-attachments/assets/c504b6d4-a070-40ae-ab43-a36479e2617b">
Blue outline
<img width="381" alt="image"
src="https://github.com/user-attachments/assets/a3e4ae40-2e97-4398-937d-447ff0f8095a">

AFTER:
<img width="1044" alt="image"
src="https://github.com/user-attachments/assets/a684dd3d-7781-48cb-9dd9-3efd7f8aaf57">
No Blue outline:
<img width="276" alt="image"
src="https://github.com/user-attachments/assets/e013b530-3dd2-4d6f-a4ce-811350cab627">


<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
  • Loading branch information
connected-znaim authored Nov 15, 2024
1 parent 9f672a6 commit 450c562
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion opentrons-ai-client/src/molecules/ChatDisplay/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,4 @@ const CodeWrapper = styled(Flex)`
background-color: ${COLORS.grey20};
border-radius: ${BORDERS.borderRadius4};
overflow: auto;
border: 1px solid ${COLORS.blue35};
`
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,11 @@ export function generateChatPrompt(

const prompt = `${t('create_protocol_prompt_robot', { robotType })}\n${t(
'application_title'
)}: ${scientificApplication}\n\n${t('description')}: ${description}\n\n${t(
)}: \n${scientificApplication}\n\n${t(
'description'
)}: \n${description}\n\n${t(
'pipette_mounts'
)}:\n\n${pipetteMounts}\n${flexGripper}\n\n${t(
)}:\n\n${pipetteMounts}${flexGripper}\n\n${t(
'modules_title'
)}:\n${modules}\n\n${t('labware_section_title')}:\n${labwares}\n\n${t(
'liquid_section_title'
Expand Down

0 comments on commit 450c562

Please sign in to comment.