Skip to content

Commit

Permalink
feat(protocol-designer, step-generation): x/Y tip positioning for asp…
Browse files Browse the repository at this point in the history
…, disp, mix (#14758)

closes AUTH-5
  • Loading branch information
jerader authored Apr 3, 2024
1 parent 80abd2e commit 3b3c8e4
Show file tree
Hide file tree
Showing 50 changed files with 3,054 additions and 981 deletions.
4 changes: 2 additions & 2 deletions protocol-designer/cypress/integration/mixSettings.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('Advanced Settings for Mix Form', () => {
cy.get('input[name="aspirate_flowRate"]').should('be.disabled')

// TipPosition Aspirate should be disabled
cy.get('[id=TipPositionField_mix_mmFromBottom]').should('be.disabled')
cy.get('[id=TipPositionIcon_mix_mmFromBottom]').should('not.be.enabled')

// Dispense Flowrate disbled
cy.get('input[name="dispense_flowRate"]').should('be.disabled')
Expand Down Expand Up @@ -91,7 +91,7 @@ describe('Advanced Settings for Mix Form', () => {
cy.get('input[name="dispense_flowRate"]').should('be.enabled')

// TipPosition Aspirate should be enabled
cy.get('[id=TipPositionField_mix_mmFromBottom]').should('be.enabled')
cy.get('[id=TipPositionIcon_mix_mmFromBottom]').should('not.be.disabled')

// Delay in aspirate and Dispense settings is enabled
cy.get('input[name="aspirate_delay_checkbox"]').should('be.enabled')
Expand Down
20 changes: 14 additions & 6 deletions protocol-designer/cypress/integration/transferSettings.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Advanced Settings for Transfer Form', () => {
it('Verify functionality of advanced settings with different pipette and labware', () => {
enterBatchEdit()

// Different Pipette disbales aspirate and dispense Flowrate and Mix settings
// Different Pipette disables aspirate and dispense Flowrate and Mix settings
// step 6 has different pipette than step 1
cy.get('[data-test="StepItem_6"]').click(batchEditClickOptions)

Expand All @@ -68,10 +68,14 @@ describe('Advanced Settings for Transfer Form', () => {
cy.get('input[name="aspirate_mix_checkbox"]').should('be.disabled')

// TipPosition Aspirate and Dispense should be disabled
cy.get('[id=TipPositionField_aspirate_mmFromBottom]').should('be.disabled')
cy.get('[id=TipPositionField_dispense_mmFromBottom]').should('be.disabled')
cy.get('[id=TipPositionIcon_aspirate_mmFromBottom]').should(
'not.be.enabled'
)
cy.get('[id=TipPositionIcon_dispense_mmFromBottom]').should(
'not.be.enabled'
)

// Dispense Flowrate and mix diabled
// Dispense Flowrate and mix disabled
cy.get('input[name="dispense_flowRate"]').should('be.disabled')
cy.get('input[name="dispense_mix_checkbox"]').should('be.disabled')

Expand Down Expand Up @@ -108,8 +112,12 @@ describe('Advanced Settings for Transfer Form', () => {
.should('be.empty')

// TipPosition Aspirate and Dispense should be enabled
cy.get('[id=TipPositionField_aspirate_mmFromBottom]').should('be.enabled')
cy.get('[id=TipPositionField_dispense_mmFromBottom]').should('be.enabled')
cy.get('[id=TipPositionIcon_aspirate_mmFromBottom]').should(
'not.be.disabled'
)
cy.get('[id=TipPositionIcon_dispense_mmFromBottom]').should(
'not.be.disabled'
)

// Delay in aspirate and Dispense settings is enabled
cy.get('input[name="aspirate_delay_checkbox"]').should('be.enabled')
Expand Down
Loading

0 comments on commit 3b3c8e4

Please sign in to comment.