Skip to content

Commit

Permalink
fix(api): change tempdeck temperature resolution,fix temp in docs
Browse files Browse the repository at this point in the history
Closes #2358
  • Loading branch information
sanni-t committed Sep 25, 2018
1 parent ea25b15 commit 3b19c5c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/docs/source/modules.rst
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Temperature Module
**********

Our temperature module acts as both a cooling and heating device. The range
of temperatures this module can reach goes from -9 to 99 degrees celsius with a resolution of 3 decimal places.
of temperatures this module can reach goes from 4 to 95 degrees celsius with a resolution of 1 degree celcius.


The temperature module has the following methods that can be accessed during a protocol.
Expand Down
3 changes: 2 additions & 1 deletion api/opentrons/commands/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,8 @@ def magdeck_calibrate():


def tempdeck_set_temp():
text = "Setting temperature deck module temperature"
text = "Setting temperature deck module temperature " \
"(rounded off to nearest integer)"
return make_command(
name=types.TEMPDECK_SET_TEMP,
payload={'text': text}
Expand Down
2 changes: 1 addition & 1 deletion api/opentrons/drivers/temp_deck/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

# Number of digits after the decimal point for temperatures being sent
# to/from Temp-Deck
GCODE_ROUNDING_PRECISION = 3
GCODE_ROUNDING_PRECISION = 0


class TempDeckError(Exception):
Expand Down
7 changes: 4 additions & 3 deletions api/opentrons/modules/tempdeck.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ def __init__(self, lw=None, port=None):
def set_temperature(self, celsius):
"""
Set temperature in degree Celsius
Range: -9 to 99 degree Celsius.
The range is limited by the 2-digit temperature display. Any input
outside of this range will be clipped to the nearest limit
Range: 4 to 95 degree Celsius (QA tested).
The internal temp range is -9 to 99 C, which is limited by the 2-digit
temperature display. Any input outside of this range will be clipped
to the nearest limit
"""
if self._driver and self._driver.is_connected():
self._driver.set_temperature(celsius)
Expand Down

0 comments on commit 3b19c5c

Please sign in to comment.